mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>
Cc: "Steven Cavanagh" <steven.cavanagh@secretlab.ca>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Editions to support fat_fallocate()
Date: Sun, 23 Dec 2007 13:23:22 -0700	[thread overview]
Message-ID: <fa686aa40712231223j18b83ff6ne5ade95a88ebbc79@mail.gmail.com> (raw)
In-Reply-To: <87tzm91u98.fsf@duaron.myhome.or.jp>

On 12/23/07, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> "Grant Likely" <grant.likely@secretlab.ca> writes:
> >
> > However, digging further, when FALLOC_FL_KEEP_SIZE is set, I don't
> > think fat_cont_expand() has the behaviour that we want to implement.
> > When that flag is set, I think we simply want to add clusters
> > associated with the file to the FAT.  We don't want to clear them or
> > map them into the page cache yet (that should be done when the
> > filesize is increased for real).
> >
> > I believe a call to fat_allocate_clusters() is all that is needed in
> > this case.  Hirofumi, please correct me if I'm wrong.
>
> Right. And we need to care the limitation on FAT specification (compatibility).

I not sure I fully understand what you mean.  Can you please
elaborate?  Are you referring to whether on not it will break other
FAT implementations if a file has more clusters allocated than it
needs?  If so, how do we decide whether or not it is acceptable?

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

  reply	other threads:[~2007-12-23 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22 21:09 Steven Cavanagh
2007-12-22 22:18 ` Grant Likely
2007-12-23 12:16   ` OGAWA Hirofumi
2007-12-23 20:23     ` Grant Likely [this message]
2008-01-13 19:49       ` OGAWA Hirofumi
     [not found] <20071214193017.7545.88989.stgit@jpe-laptop>
2007-12-14 20:12 ` Grant Likely
  -- strict thread matches above, loose matches on Subject: below --
2007-12-12  0:20 Steven Cavanagh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40712231223j18b83ff6ne5ade95a88ebbc79@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steven.cavanagh@secretlab.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®