From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
dbrownell@users.sourceforge.net
Subject: Re: [PATCH/RFC] spi: Change modalias from a pointer to a character array
Date: Mon, 12 May 2008 16:20:17 -0600 [thread overview]
Message-ID: <fa686aa40805121520y979ee37ga83221b74b35afe1@mail.gmail.com> (raw)
In-Reply-To: <20080512151805.4c2763b9.akpm@linux-foundation.org>
On Mon, May 12, 2008 at 4:18 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Fri, 09 May 2008 11:32:28 -0600
> Grant Likely <grant.likely@secretlab.ca> wrote:
>
> > From: Grant Likely <grant.likely@secretlab.ca>
> >
> > Currently, 'modalias' in the spi_device structure is a 'const char *'.
> > The spi_new_device() function fills in the modalias value from a passed
> > in spi_board_info data block. Since it is a pointer copy, the new
> > spi_device remains dependent on the spi_board_info structure after the
> > new spi_device is registered (no other fields in spi_device directly
> > depend on the spi_board_info structure; all of the other data is copied).
> >
<snip>
>
> I'm not really able to work out if this is a needed-in-2.6.26 thing. I
> assumed "not".
That's correct. I'm also not even 100% sure that this is the best
approach. I'm waiting/hoping for feedback from David.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-05-12 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 17:32 Grant Likely
2008-05-12 22:18 ` Andrew Morton
2008-05-12 22:20 ` Grant Likely [this message]
2008-05-12 22:56 ` David Brownell
2008-05-22 0:03 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40805121520y979ee37ga83221b74b35afe1@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®