From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760623AbYEXGoP (ORCPT ); Sat, 24 May 2008 02:44:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756035AbYEXGn7 (ORCPT ); Sat, 24 May 2008 02:43:59 -0400 Received: from an-out-0708.google.com ([209.85.132.247]:45448 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755615AbYEXGn7 (ORCPT ); Sat, 24 May 2008 02:43:59 -0400 Message-ID: Date: Sat, 24 May 2008 00:43:58 -0600 From: "Grant Likely" To: "David Brownell" Subject: Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration. Cc: linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, fabrizio.garetto@gmail.com, jonsmirl@gmail.com In-Reply-To: <200805211717.13206.david-b@pacbell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> <20080516193608.28030.34968.stgit@trillian.secretlab.ca> <200805211717.13206.david-b@pacbell.net> X-Google-Sender-Auth: d7131d7dedb8551f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 21, 2008 at 6:17 PM, David Brownell wrote: > On Friday 16 May 2008, Grant Likely wrote: >> >> This patch splits the allocation and registration portions of code out >> of spi_new_device() and creates three new functions; spi_alloc_device(), >> spi_register_device(), and spi_device_release(). > > I have no problem with the first two, but why the last? > > If the devices are always allocated by spi_alloc_device() as > they should be -- probably through an intermediary -- the > only public function necessary for that cleanup should be > the existing spi_dev_put(). Ah, okay. I'm still a bit fuzzy on the device model conventions. I'll remove that then. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.