From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759880AbYEXQvi (ORCPT ); Sat, 24 May 2008 12:51:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759326AbYEXQvD (ORCPT ); Sat, 24 May 2008 12:51:03 -0400 Received: from an-out-0708.google.com ([209.85.132.245]:64925 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757459AbYEXQuw (ORCPT ); Sat, 24 May 2008 12:50:52 -0400 Message-ID: Date: Sat, 24 May 2008 10:50:52 -0600 From: "Grant Likely" To: "David Brownell" Subject: Re: [PATCH 3/4] spi: Add OF binding support for SPI busses Cc: avorontsov@ru.mvista.com, linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, fabrizio.garetto@gmail.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> <20080516193613.28030.13950.stgit@trillian.secretlab.ca> <20080521151928.GA28857@polina.dev.rtsoft.ru> <200805221905.32288.david-b@pacbell.net> X-Google-Sender-Auth: f6e5495e66ca06b6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 24, 2008 at 12:26 AM, Grant Likely wrote: > On Thu, May 22, 2008 at 8:05 PM, David Brownell wrote: >> On Wednesday 21 May 2008, Anton Vorontsov wrote: >>> > +++ b/drivers/spi/spi_of.c >>> >>> I think better placement for this is drivers/of, no? >> >> Yes please. > > Okay, I wasn't sure. Will do. I'm having second thoughts about this. I think this code is more SPI centric than it is OF centric. ie. it is usable by all spi masters in an OF enabled system, but it is not usable by all OF devices in an SPI enabled system. Or, in other words; it adds OF support to SPI, not the other way around. I think drivers/spi is the right place for this to live. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.