From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Pierre Ossman" <drzeus-mmc@drzeus.cx>
Cc: "Anton Vorontsov" <avorontsov@ru.mvista.com>,
"David Brownell" <dbrownell@users.sourceforge.net>,
"Jochen Friedrich" <jochen@scram.de>,
"Segher Boessenkool" <segher@kernel.crashing.org>,
"Gary Jennejohn" <garyj@denx.de>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver
Date: Mon, 16 Jun 2008 08:13:06 -0600 [thread overview]
Message-ID: <fa686aa40806160713q51f3d132w2fef2a2473faad1@mail.gmail.com> (raw)
In-Reply-To: <20080614175723.209e93dc@mjolnir.drzeus.cx>
On Sat, Jun 14, 2008 at 9:57 AM, Pierre Ossman <drzeus-mmc@drzeus.cx> wrote:
> On Thu, 5 Jun 2008 20:16:24 +0400
> Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
>> Here is v3. I'm out of ideas if you won't like it. :-)
>>
>> v3:
>> - Now these bindings are using bus notifiers chain, thus we adhere to the
>> spi bus.
>>
>
> Now this was nice and clean. I take it Grant doesn't like this version
> though. What's the downside of it?
No, I don't. I like the v2 approach better as long as it is been
changed to address your comments. This approach I think is needlessly
complex and non-obvious (relying on the notification chain instead of
being part of the probe call). It will break in non-obvious ways if
the notifier module is loaded after the mmc_spi driver.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-06-16 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 16:16 Anton Vorontsov
2008-06-05 16:45 ` Grant Likely
2008-06-05 17:27 ` Anton Vorontsov
2008-06-05 17:36 ` Grant Likely
2008-06-05 18:00 ` Anton Vorontsov
2008-06-05 18:18 ` Grant Likely
2008-06-05 18:31 ` Anton Vorontsov
2008-06-05 18:42 ` Grant Likely
2008-06-14 15:57 ` Pierre Ossman
2008-06-16 13:23 ` Anton Vorontsov
2008-06-16 14:13 ` Grant Likely [this message]
2008-07-03 3:26 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40806160713q51f3d132w2fef2a2473faad1@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=drzeus-mmc@drzeus.cx \
--cc=g.liakhovetski@gmx.de \
--cc=garyj@denx.de \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®