From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754204AbZBRPse (ORCPT ); Wed, 18 Feb 2009 10:48:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751479AbZBRPs0 (ORCPT ); Wed, 18 Feb 2009 10:48:26 -0500 Received: from el-out-1112.google.com ([209.85.162.181]:27454 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbZBRPs0 (ORCPT ); Wed, 18 Feb 2009 10:48:26 -0500 MIME-Version: 1.0 In-Reply-To: References: <20090218151132.476.81706.stgit@localhost.localdomain> <20090218152913.GA26448@suse.de> Date: Wed, 18 Feb 2009 08:48:24 -0700 Message-ID: Subject: Re: [PATCH] Export device_add_attributes() so drivers can use it. From: Grant Likely To: Kay Sievers Cc: Greg KH , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 18, 2009 at 8:45 AM, Kay Sievers wrote: > On Wed, Feb 18, 2009 at 16:29, Greg KH wrote: >> On Wed, Feb 18, 2009 at 08:11:34AM -0700, Grant Likely wrote: >>> From: Grant Likely >>> >>> I find myself using the pattern of device_add_attributes() and >>> device_remove_attributes() frequently in my drivers. Rather than >>> reinventing the wheel every time, I'm floating this patch to export >>> the symbols to see how it is received. If this looks okay then I'll >>> rework my drivers and post additional patches to use these functions. >> >> No objection from me, as long as the symbols are EXPORT_SYMBOL_GPL(), >> like the rest of the driver core. Is that ok with you? > > These functions used outside the core create attributes after the > uevent is sent, and userspace will not see these files at event time. > This is in most cases a pretty broken behavior. Is that the expected > behavior in your drivers? ??? I don't follow what you mean. I'm using these functions to allow the driver to add device attribs; primarily for debugging knobs and controls. Userspace will see the files after the driver is bound to the device. The uevent doesn't really come into play. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.