From: Grant Likely <grant.likely@secretlab.ca>
To: John Linn <John.Linn@xilinx.com>
Cc: John Linn <linnj@xilinx.com>,
John Williams <john.williams@petalogix.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Michal Simek <michal.simek@petalogix.com>,
David DeBonis <ddeboni@xilinx.com>,
Stephen Neuendorffer <stephenn@xilinx.com>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>
Subject: Re: Xilinx SYSACE driver and 8-bit attachment
Date: Wed, 7 Oct 2009 08:52:34 -0600 [thread overview]
Message-ID: <fa686aa40910070752k1b954a32v1ae6a2e5a089fc5e@mail.gmail.com> (raw)
In-Reply-To: <192797ad-5dd4-4ebe-8db3-d381bb949e1e@VA3EHSMHS029.ehs.local>
On Wed, Oct 7, 2009 at 8:42 AM, John Linn <John.Linn@xilinx.com> wrote:
>> -----Original Message-----
>> From: John Linn
>> Sent: Wednesday, October 07, 2009 8:24 AM
>> To: 'Grant Likely'; John Williams
>> Cc: Linux Kernel list; Michal Simek; David DeBonis; Stephen Neuendorffer; devicetree-discuss
>> Subject: RE: Xilinx SYSACE driver and 8-bit attachment
>>
>> I'll look to see if something has changed. It's not clear to me if it has ever been right.
>>
>> It look like we normally use 16 bit mode as that's how BSB generates the system by default.
>>
>> Thanks,
>> John
>>
>> > -----Original Message-----
>> > From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely
>> > Sent: Wednesday, October 07, 2009 7:35 AM
>> > To: John Williams
>> > Cc: Linux Kernel list; Michal Simek; John Linn; David DeBonis; Stephen Neuendorffer; devicetree-
>> > discuss
>> > Subject: Re: Xilinx SYSACE driver and 8-bit attachment
>> >
>> > [Added devicetree-discuss to cc: list]
>> >
>> > On Wed, Oct 7, 2009 at 1:13 AM, John Williams
>> > <john.williams@petalogix.com> wrote:
>> > > Hi Grant (it's your driver :) and David D ( and your DTS generator :)
>> > [...]
>> > > if (of_find_property(op->node, "8-bit", NULL))
>> > [...]
>> > > doesn't match the properties generated by Xilinx's device tree generator:
>> > [...]
>> > > xlnx,mem-width = <0x8>;
>
> Do you know if the 8 bit mode was ever tested with the "8-bit" property in the tree?
>
> I don't see anything in the device tree generator history to say we ever did that "8-bit", but maybe I'm missing something.
>
> We are just generating the parameters from the h/w and the memory width is it. We can always put something in there special, but it seems silly if it was never used anyway.
Don't forget that Virtex and Microblaze are not the only users of this
driver. There is a AMCC 440 board which uses the sysace as a CF
adapter. 8-bit was definitely tested and is in use.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-10-07 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 7:13 John Williams
2009-10-07 13:34 ` Grant Likely
2009-10-07 14:24 ` John Linn
2009-10-07 23:41 ` John Williams
2009-10-07 23:44 ` John Linn
2009-10-07 23:46 ` John Williams
2009-10-07 14:42 ` John Linn
2009-10-07 14:52 ` Grant Likely [this message]
2009-10-07 16:18 ` Stephen Neuendorffer
2009-10-07 23:44 ` John Williams
2009-10-07 23:47 ` John Linn
2009-10-07 23:48 ` Stephen Neuendorffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40910070752k1b954a32v1ae6a2e5a089fc5e@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=John.Linn@xilinx.com \
--cc=ddeboni@xilinx.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=john.williams@petalogix.com \
--cc=linnj@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@petalogix.com \
--cc=stephenn@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®