From: Grant Likely <grant.likely@secretlab.ca>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Scott Wood <scottwood@freescale.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@ozlabs.org
Subject: Re: [patch 06/13] powerpc: Fixup last users of irq_chip->typename
Date: Sat, 21 Nov 2009 01:01:41 -0700 [thread overview]
Message-ID: <fa686aa40911210001u699031a0h2b3818b68c212d69@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0911182141060.24119@localhost.localdomain>
On Wed, Nov 18, 2009 at 1:41 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 18 Nov 2009, Scott Wood wrote:
>> On Tue, Nov 17, 2009 at 10:50:53PM +0000, Thomas Gleixner wrote:
>> > Index: linux-2.6/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
>> > ===================================================================
>> > --- linux-2.6.orig/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
>> > +++ linux-2.6/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
>> > @@ -69,7 +69,7 @@ static void pq2ads_pci_unmask_irq(unsign
>> > }
>> >
>> > static struct irq_chip pq2ads_pci_ic = {
>> > - .typename = "PQ2 ADS PCI",
>> > + .name = "PQ2 ADS PCI",
>> > .name = "PQ2 ADS PCI",
>> > .end = pq2ads_pci_unmask_irq,
>> > .mask = pq2ads_pci_mask_irq,
>>
>> Duplicate ".name"...
>
> Darn.
Other than that, looks good to me.
Acked-by: Grant Likely <grant.likely@secretlab.ca>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-11-21 8:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:50 [patch 00/13] Remove the last leftover of the irq_chip migration: irq_chip.typename Thomas Gleixner
2009-11-17 22:50 ` [patch 01/13] x86: Fixup last users of irq_chip->typename Thomas Gleixner
2009-11-17 22:50 ` [patch 02/13] xtensa: " Thomas Gleixner
2009-11-17 22:50 ` [patch 03/13] um: " Thomas Gleixner
2009-11-17 22:50 ` [patch 04/13] sparc: " Thomas Gleixner
2009-11-18 7:26 ` David Miller
2009-11-17 22:50 ` [patch 05/13] sh: " Thomas Gleixner
2009-11-18 1:52 ` Paul Mundt
2009-11-17 22:50 ` [patch 06/13] powerpc: " Thomas Gleixner
2009-11-18 17:55 ` Scott Wood
2009-11-18 20:41 ` Thomas Gleixner
2009-11-19 9:44 ` [patch] powerpc: Fixup last users of irq_chip->typename - V2 Thomas Gleixner
2009-11-19 21:48 ` Geoff Levand
2009-11-21 8:01 ` Grant Likely [this message]
2009-11-17 22:50 ` [patch 07/13] parisc: Fixup last users of irq_chip->typename Thomas Gleixner
2009-11-18 22:13 ` Kyle McMartin
2009-11-17 22:51 ` [patch 08/13] mips: " Thomas Gleixner
2009-11-17 23:05 ` Ralf Baechle
2009-11-17 23:09 ` Thomas Gleixner
2009-11-17 23:22 ` Ralf Baechle
2009-11-17 22:51 ` [patch 09/13] m32r: " Thomas Gleixner
2009-11-18 3:29 ` Hirokazu Takata
2009-11-17 22:51 ` [patch 10/13] cris: " Thomas Gleixner
2009-11-19 11:15 ` Jesper Nilsson
2009-11-19 11:18 ` Thomas Gleixner
2009-11-17 22:51 ` [patch 11/13] arm: " Thomas Gleixner
2009-11-17 22:51 ` [patch 12/13] alpha: " Thomas Gleixner
2009-12-01 3:52 ` Matt Turner
2009-11-17 22:51 ` [patch 13/13] genirq: Remove typename from struct irq_chip Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40911210001u699031a0h2b3818b68c212d69@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=scottwood@freescale.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome