From: Grant Likely <grant.likely@secretlab.ca>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Kumar Gala <galak@kernel.crashing.org>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
devicetree-discuss@lists.ozlabs.org,
David Brownell <dbrownell@users.sourceforge.net>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 32/38] don't use __exit_p to wrap plat_mpc8xxx_spi_remove
Date: Tue, 24 Nov 2009 14:42:22 -0700 [thread overview]
Message-ID: <fa686aa40911241342we68d831n4bd6e637ff21f939@mail.gmail.com> (raw)
In-Reply-To: <1259096853-18909-32-git-send-email-u.kleine-koenig@pengutronix.de>
2009/11/24 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> The function plat_mpc8xxx_spi_remove is defined using __devexit, so don't
> use __exit_p but __devexit_p to wrap it.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Obviously correct.
Acked-by: Grant Likely <grant.likely@secretlab.ca>
g.
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: linux-kernel@vger.kernel.org
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Cc: spi-devel-general@lists.sourceforge.net
> ---
> drivers/spi/spi_mpc8xxx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
> index 0fd0ec4..1d98be9 100644
> --- a/drivers/spi/spi_mpc8xxx.c
> +++ b/drivers/spi/spi_mpc8xxx.c
> @@ -900,7 +900,7 @@ static int __devexit plat_mpc8xxx_spi_remove(struct platform_device *pdev)
> MODULE_ALIAS("platform:mpc8xxx_spi");
> static struct platform_driver mpc8xxx_spi_driver = {
> .probe = plat_mpc8xxx_spi_probe,
> - .remove = __exit_p(plat_mpc8xxx_spi_remove),
> + .remove = __devexit_p(plat_mpc8xxx_spi_remove),
> .driver = {
> .name = "mpc8xxx_spi",
> .owner = THIS_MODULE,
> --
> 1.6.5.2
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-11-24 21:42 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 21:06 [PATCH 01/38] move asic3_remove to .devexit.text Uwe Kleine-König
2009-11-24 21:06 ` [PATCH 02/38] move atp870u_remove " Uwe Kleine-König
2009-11-24 21:06 ` [PATCH 03/38] move excite_nand_remove " Uwe Kleine-König
2009-11-24 21:06 ` [PATCH 04/38] move ilo_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 05/38] move initio_remove_one " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 06/38] move iodev_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 07/38] move lasi700_driver_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 08/38] move mcf_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 09/38] move megaraid_detach_one " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 11/38] move mpc85xx_pci_err_remove to .devexit.text Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 12/38] move mv64x60_pci_err_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 13/38] don't use __exit_p to wrap mxcnd_remove Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 14/38] move NCR_Q720_remove to .devexit.text Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 15/38] move s3c_adc_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 16/38] move s3c_pwm_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 17/38] move sc26xx_driver_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 18/38] move sgiwd93_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 19/38] move snirm710_driver_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 20/38] move spidev_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 21/38] move stex_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 22/38] move vhci_hcd_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 23/38] move zalon_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 24/38] move lis3l02dq_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 25/38] move sca3000_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 26/38] move vlynq_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 27/38] move bfad_pci_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 28/38] don't use __exit_p to wrap ds1302_rtc_remove Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 29/38] move mc33880_remove to .devexit.text Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 30/38] move mipid_spi_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 31/38] move pcf2123_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 32/38] don't use __exit_p to wrap plat_mpc8xxx_spi_remove Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 33/38] don't use __exit_p to wrap sh_mobile_ceu_remove Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 34/38] move vpfe_remove to .devexit.text Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 35/38] move vpif_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 36/38] move vpss_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 37/38] don't use __devexit_p to wrap sci_remove Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 38/38] don't use __exit_p to wrap composite_unbind Uwe Kleine-König
2009-11-25 1:36 ` [PATCH 28/38] don't use __exit_p to wrap ds1302_rtc_remove Paul Mundt
2009-11-24 21:42 ` Grant Likely [this message]
2009-11-26 8:23 ` [PATCH 29/38] move mc33880_remove to .devexit.text Richard Röjfors
2009-11-24 21:22 ` [PATCH 20/38] move spidev_remove " Mike Frysinger
2009-11-25 8:02 ` [PATCH 16/38] move s3c_pwm_remove " Peter Korsgaard
2009-12-03 22:07 ` [PATCH 15/38] move s3c_adc_remove " Ben Dooks
2009-12-03 22:10 ` Uwe Kleine-König
2009-11-25 9:19 ` [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p Franco Fichtner
2009-11-25 9:23 ` [PATCH] " Uwe Kleine-König
2009-11-25 1:22 ` [PATCH 08/38] move mcf_remove to .devexit.text Greg Ungerer
2009-11-27 8:16 ` [PATCH 06/38] move iodev_remove " Ralf Baechle
2009-11-24 21:38 ` [PATCH 02/38] move atp870u_remove " James Bottomley
2009-11-25 9:26 ` Uwe Kleine-König
2009-11-25 13:38 ` Bartlomiej Zolnierkiewicz
2009-11-24 23:24 ` [PATCH 01/38] move asic3_remove " Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40911241342we68d831n4bd6e637ff21f939@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®