From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: devicetree-discuss@lists.ozlabs.org, monstr@monstr.eu,
linux-kernel@vger.kernel.org, jeremy.kerr@canonical.com
Subject: Re: [PATCH 2/2] of/flattree: Make unflatten_device_tree() safe to call from any arch
Date: Mon, 22 Feb 2010 16:11:48 -0700 [thread overview]
Message-ID: <fa686aa41002221511r67c79534od562bef934c4d7a7@mail.gmail.com> (raw)
In-Reply-To: <20100223095118.bed93bac.sfr@canb.auug.org.au>
On Mon, Feb 22, 2010 at 3:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Grant,
>
> On Mon, 22 Feb 2010 08:50:59 -0700 Grant Likely <grant.likely@secretlab.ca> wrote:
>>
>> - If CONFIG_OF_FLATTREE is not set, then make unflatten_device_tree()
>> an empty #define.
>
> Any reason not to make this a static inline?
>
>> +#define unflatten_device_tree() do {} while(0)
>
> static inline void unflatten_device_tree(void) {}
No reason, just wasn't thinking of that. I've changed this.
g.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2010-02-22 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 15:50 [PATCH 0/2] Make of_fdt conditionally compile gracefully Grant Likely
2010-02-22 15:50 ` [PATCH 1/2] of/flattree: make of_fdt.h safe to unconditionally include Grant Likely
2010-02-22 15:50 ` [PATCH 2/2] of/flattree: Make unflatten_device_tree() safe to call from any arch Grant Likely
2010-02-22 22:51 ` Stephen Rothwell
2010-02-22 23:11 ` Grant Likely [this message]
2010-02-22 23:25 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41002221511r67c79534od562bef934c4d7a7@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jeremy.kerr@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome