From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: s3c: Fix typo in one comment
Date: Mon, 15 Nov 2021 09:43:26 +0100 [thread overview]
Message-ID: <fa6a55a9-1c27-e9a8-739e-fd7ec34e3b76@canonical.com> (raw)
In-Reply-To: <20211113031117.33727-1-wangborong@cdjrlc.com>
On 13/11/2021 04:11, Jason Wang wrote:
> The double `would' in the comment might be repeated. Remove one of them
> from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> arch/arm/mach-s3c/mach-gta02.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
> index 418939ce0fc3..174b2e55ea16 100644
> --- a/arch/arm/mach-s3c/mach-gta02.c
> +++ b/arch/arm/mach-s3c/mach-gta02.c
> @@ -393,9 +393,9 @@ static struct s3c2410_nand_set __initdata gta02_nand_sets[] = {
> [0] = {
> /*
> * This name is also hard-coded in the boot loaders, so
> - * changing it would would require all users to upgrade
> - * their boot loaders, some of which are stored in a NOR
> - * that is considered to be immutable.
> + * changing it would require all users to upgrade their
> + * boot loaders, some of which are stored in a NOR that
> + * is considered to be immutable.
> */
This is a legacy platform, bigger set of cleanups are accepted but a
patch which changes only one typo, is not. Especially that you change
here three lines for this simple one typo.
Please send a bigger cleanup for all of such issues or skip it.
Best regards,
Krzysztof
prev parent reply other threads:[~2021-11-15 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 3:11 Jason Wang
2021-11-15 8:43 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa6a55a9-1c27-e9a8-739e-fd7ec34e3b76@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®