Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC page_pools

[Jesper Dangaard Brouer <hawk@kernel.org>]

On 05/11/2025 21.07, Mina Almasry wrote:
> diff --git a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> index 0e2b703c673a..f63ffdd3b3ba 100644
> --- a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> +++ b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> @@ -8,6 +8,8 @@
>   #include "gve.h"
>   #include "gve_utils.h"
>   
> +#include "net/netdev_queues.h"
> +

Shouldn't this be with "<net/netdev_queues.h>" ?

And why include this and not net/page_pool/types.h that you just
modified in previous patch?

>   int gve_buf_ref_cnt(struct gve_rx_buf_state_dqo *bs)
>   {
>   	return page_count(bs->page_info.page) - bs->page_info.pagecnt_bias;
> @@ -263,6 +265,8 @@ struct page_pool *gve_rx_create_page_pool(struct gve_priv *priv,
>   	if (priv->header_split_enabled) {
>   		pp.flags |= PP_FLAG_ALLOW_UNREADABLE_NETMEM;
>   		pp.queue_idx = rx->q_num;
> +		if  (netif_rxq_has_unreadable_mp(priv->dev, rx->q_num))
> +			pp.pool_size = PAGE_POOL_MAX_RING_SIZE;
>   	}
>