mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre Gondois <pierre.gondois@arm.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-kernel@vger.kernel.org,
	Ashok Raj <ashok.raj@oss.qualcomm.com>,
	James Morse <james.morse@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Oliver O'Halloran <oohall@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Pawel Chmielewski <pawel.chmielewski@intel.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Avadhut Naik <avadhut.naik@amd.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Kai-Heng Feng <kaihengf@nvidia.com>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Breno Leitao <leitao@debian.org>,
	Terry Bowman <terry.bowman@amd.com>,
	Dan Williams <djbw@kernel.org>,
	linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
	acpica-devel@lists.linux.dev
Subject: Re: [PATCH v1 05/19] PCI/AER: Embed aer_capability_regs copy in struct aer_recover_entry
Date: Wed, 18 Nov 2026 16:10:02 +0100	[thread overview]
Message-ID: <fa6c1f8d-d372-4737-8c57-528a6470d2a7@arm.com> (raw)
In-Reply-To: <avw-NChMgIjwFuv1@wunner.de>

Hello Lukas,

On 11/17/26 12:44, Lukas Wunner wrote:
> On Tue, Nov 17, 2026 at 12:10:15PM +0100, Pierre Gondois wrote:
>> commit e2abc47a5a1a ("ACPI: APEI: Fix AER info corruption when error
>> status data has multiple sections") passed to aer_recover_queue() a
>> newly allocated copy of pcie_err->aer_info instead of providing a
>> pointer to the ghes struct. This prevented corruptions of the ghes
>> record (in case the ghes record was re-used for a new error before
>> the previous error was logged).
> Since commit eddba19b8b5f ("PCI/AER: Support Advisory Non-Fatal Errors"),
> aer_regs is modified for a recursive invocation of __pci_print_aer().
> The copy is necessary because we don't want to modify a buffer owned by
> platform firmware.
>
>> +++ b/drivers/pci/pcie/aer.c
>> @@ -1352,7 +1352,7 @@ struct aer_recover_entry {
>>   	u8	devfn;
>>   	u16	domain;
>>   	int	severity;
>> -	struct aer_capability_regs *regs;
>> +	struct aer_capability_regs regs;
>>   };
> This increases stack usage significantly in aer_recover_queue(),
> which is not good.  A kzalloc() allocation may be better suited
> for such a large struct, instead of relying on the stack.
>
>> @@ -1374,24 +1374,14 @@ static void aer_recover_work_func(struct work_struct *work)
>>   					   PCI_SLOT(entry.devfn),
>>   					   PCI_FUNC(entry.devfn));
>>   		else
>> -			pci_print_aer(pdev, entry.severity, entry.regs);
>> +			pci_print_aer(pdev, entry.severity, &entry.regs);
>>   
>> -		regs = entry.regs;
>> +		regs = &entry.regs;
>>   		if (entry.severity == AER_CORRECTABLE)
>>   			err = regs->cor_status & ~regs->cor_mask;
>>   		else
>>   			err = regs->uncor_status & ~regs->uncor_mask;
>>   
>> -		/*
>> -		 * Memory for aer_capability_regs(entry.regs) is being
>> -		 * allocated from the ghes_estatus_pool to protect it from
>> -		 * overwriting when multiple sections are present in the
>> -		 * error status. Thus free the same after processing the
>> -		 * data.
>> -		 */
>> -		ghes_estatus_pool_region_free((unsigned long)entry.regs,
>> -					    sizeof(struct aer_capability_regs));
>> -
> So you're removing the call to ghes_estatus_pool_region_free() from the
> worker...
>
>> @@ -1441,17 +1431,18 @@ void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn,
>>   		.devfn		= devfn,
>>   		.domain		= domain,
>>   		.severity	= severity,
>> -		.regs		= aer_regs,
>> +		.regs		= *aer_regs,
>>   	};
>>   
>> +	ghes_estatus_pool_region_free((unsigned long)aer_regs,
>> +				      sizeof(struct aer_capability_regs));
>> +
> ... and instead call it earlier, before even launching the worker.
> So where's the benefit?  You've traded less memory usage in the
> pool for higher stack usage.  How is that useful?

This patch is an intermediate step toward:
[PATCH v1 06/19] ACPI: APEI: Remove aer allocation in ghes_handle_aer()

The final goal of these 2 patches being to remove the dependency
of ghes_handle_aer() over the ghes_estatus_pool. Just using kzallac() should
work aswell I think.



  reply	other threads:[~2026-11-18 15:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:10 [PATCH v1 00/19] ACPI: APEI: Share CPER reporting between GHES and extlog Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 01/19] x86/APEI: Extract common CPER memory error reporting helper Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 02/19] x86/APEI: Report Memory Error Section 2 through MCE Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 03/19] ras: Bound CPER FRU strings in trace events Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 04/19] ACPI: APEI: Use empty FRU values if valid bit is absent Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 05/19] PCI/AER: Embed aer_capability_regs copy in struct aer_recover_entry Pierre Gondois
2026-11-17 11:44   ` Lukas Wunner
2026-11-18 15:10     ` Pierre Gondois [this message]
2026-11-17 11:10 ` [PATCH v1 06/19] ACPI: APEI: Remove aer allocation in ghes_handle_aer() Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 07/19] ACPI: extlog: Provide HEST generic data to extlog_print_pcie() Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 08/19] ACPI: extlog: Align extlog_print_pcie() and ghes_handle_aer() Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 09/19] ACPI: extlog: Report errors independently of RAS consumers Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 10/19] ACPI: extlog: Simplify fatal record printing Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 11/19] RAS: Remove unused ras_userspace_consumers() Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 12/19] ACPI: extlog: Extract CPER reporting from acpi_extlog Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 13/19] ACPI: APEI: Share helpers with the common CPER reporter Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 14/19] ACPI: APEI: Return status from cxl_cper_post_event() Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 15/19] ACPI: APEI: Extend common CPER reporting for GHES section types Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 16/19] ACPI: extlog: Report error severity using GHES bindings in MCE Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 17/19] ACPI: APEI: Share the extlog PCIe handler with GHES Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 18/19] ACPI: APEI: Route GHES section reporting through extlog Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 19/19] PCI/ERR: Avoid NULL bridge pointer Pierre Gondois
2026-11-17 11:50   ` Lukas Wunner
2026-11-17 18:57     ` Kuppuswamy Sathyanarayanan
2026-11-18 15:11       ` Pierre Gondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa6c1f8d-d372-4737-8c57-528a6470d2a7@arm.com \
    --to=pierre.gondois@arm.com \
    --cc=acpica-devel@lists.linux.dev \
    --cc=ashok.raj@oss.qualcomm.com \
    --cc=avadhut.naik@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=djbw@kernel.org \
    --cc=fabio.m.de.francesco@linux.intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jic23@kernel.org \
    --cc=kaihengf@nvidia.com \
    --cc=leitao@debian.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukas@wunner.de \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=mahesh@linux.ibm.com \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oohall@gmail.com \
    --cc=pawel.chmielewski@intel.com \
    --cc=rafael@kernel.org \
    --cc=terry.bowman@amd.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®