From: David Laight <David.Laight@ACULAB.COM>
To: 'Linus Torvalds' <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>
Cc: Franck Grosjean <fgrosjea@redhat.com>,
Phil Auld <pauld@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] pipe: Make a partially-satisfied blocking read wait for more
Date: Mon, 26 Jun 2023 09:31:52 +0000 [thread overview]
Message-ID: <fa6de786ee1241c6ba54c3cce0b980aa@AcuMS.aculab.com> (raw)
In-Reply-To: <CAHk-=wiXr2WTDFZi6y8c4TjZXfTnw28BkLF9Fpe=SyvmSCvP2Q@mail.gmail.com>
From: Linus Torvalds
> Sent: 23 June 2023 23:42
>
> On Fri, 23 Jun 2023 at 15:34, David Howells <dhowells@redhat.com> wrote:
> >
> > Can you consider merging something like the attached patch? Unfortunately,
> > there are applications out there that depend on a read from pipe() waiting
> > until the buffer is full under some circumstances. Patch a28c8b9db8a1
> > removed the conditionality on there being an attached writer.
>
> This patch seems actively wrong, in that now it's possibly waiting for
> data that won't come, even if it's nonblocking.
I think it pretty much breaks:
command | tee file
where 'command' is careful to fflush(stdout).
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-06-26 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 22:34 David Howells
2023-06-23 22:41 ` Linus Torvalds
2023-06-23 23:08 ` Linus Torvalds
2023-06-23 23:32 ` Linus Torvalds
2023-06-26 9:16 ` David Laight
2023-06-26 9:31 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa6de786ee1241c6ba54c3cce0b980aa@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=fgrosjea@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®