From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dzmitry Sankouski <dsankouski@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arch: arm64: dts: qcom: sdm845-starqltechn: fix max77705 interrupts
Date: Fri, 12 Sep 2025 12:36:41 +0200 [thread overview]
Message-ID: <fa6f147f-c4fd-4267-82e3-139129caccbe@oss.qualcomm.com> (raw)
In-Reply-To: <20250909-starqltechn-correct_max77705_nodes-v2-3-e4174d374074@gmail.com>
On 9/9/25 9:22 PM, Dzmitry Sankouski wrote:
> Since max77705 has a register, which indicates interrupt source, it acts
> as an interrupt controller.
>
> Use max77705 as an interrupt controller for charger and fuelgauge
> subdevices.
"""
Direct MAX77705's subdevices to use the IC's internal interrupt
controller, instead of listening to every interrupt fired by the
chip towards the host device.
"""
Fixes: 7a88a931d095 ("arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC")
Konrad>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes for v2:
> - fix commit msg header prefix to 'arm64: dts: qcom: sdm845-starqltechn:'
> - remove binding header for interrupt numbers
> - make interrupt-cells 1, because irq trigger type is not used
> ---
> arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> index 8a1e4c76914c..597e25d27d76 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> @@ -584,13 +584,15 @@ &uart9 {
> &i2c14 {
> status = "okay";
>
> - pmic@66 {
> + max77705: pmic@66 {
> compatible = "maxim,max77705";
> reg = <0x66>;
> interrupt-parent = <&pm8998_gpios>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> pinctrl-0 = <&pmic_int_default>;
> pinctrl-names = "default";
> + #interrupt-cells = <1>;
>
> leds {
> compatible = "maxim,max77705-rgb";
> @@ -629,8 +631,8 @@ max77705_charger: charger@69 {
> reg = <0x69>;
> compatible = "maxim,max77705-charger";
> monitored-battery = <&battery>;
> - interrupt-parent = <&pm8998_gpios>;
> - interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&max77705>;
> + interrupts = <0>;
> };
>
> fuel-gauge@36 {
> @@ -638,8 +640,8 @@ fuel-gauge@36 {
> compatible = "maxim,max77705-battery";
> power-supplies = <&max77705_charger>;
> maxim,rsns-microohm = <5000>;
> - interrupt-parent = <&pm8998_gpios>;
> - interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&max77705>;
> + interrupts = <2>;
> };
> };
>
>
prev parent reply other threads:[~2025-09-12 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 19:22 [PATCH v2 0/3] starqltechn: fix max77705 device irqs Dzmitry Sankouski
2025-09-09 19:22 ` [PATCH v2 1/3] dt-bindings: max77705: add interrupt-controller node Dzmitry Sankouski
2025-09-09 19:22 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-starqltechn: remove (address|size)-cells Dzmitry Sankouski
2025-09-12 10:35 ` Konrad Dybcio
2025-09-09 19:22 ` [PATCH v2 3/3] arch: arm64: dts: qcom: sdm845-starqltechn: fix max77705 interrupts Dzmitry Sankouski
2025-09-12 10:36 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa6f147f-c4fd-4267-82e3-139129caccbe@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®