From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA81C4332F for ; Mon, 13 Nov 2023 04:17:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbjKMER1 (ORCPT ); Sun, 12 Nov 2023 23:17:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjKMERY (ORCPT ); Sun, 12 Nov 2023 23:17:24 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF121729 for ; Sun, 12 Nov 2023 20:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699849002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7aB5COy4QAe+eFccHV1YqyKzO84zBoVzPy0R2GMj01o=; b=hUvvdqtyCi5jfCJAKsSc3amNcmqs75DzyhnEXm2yR4dCpZbhn2M+esF3MxLinCeDvm2Phx NgVLtePNho+Yaj3S842B+tbcaqKxflS85S+am333fUu0TFTGLPMVNpkut5hfaHPsYQeHrb 3QMH8fcLL7iTc0t15ClwyWDCW2Vykxw= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-zuMCbQLoP1Oiqh8aq4BTaQ-1; Sun, 12 Nov 2023 23:16:40 -0500 X-MC-Unique: zuMCbQLoP1Oiqh8aq4BTaQ-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-280184b2741so3787468a91.0 for ; Sun, 12 Nov 2023 20:16:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699848999; x=1700453799; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7aB5COy4QAe+eFccHV1YqyKzO84zBoVzPy0R2GMj01o=; b=XrzDYe5mAVbvwhEU4+Hf3t5oViByXgF0CmWmtWpUx7vgMvnHmvgvkfQQdusBaO4J2a uX0pgLW42Nw5Aojdx0gt2hrwbrP4BjHMlIHEiUH+TaAKCpo93IgJAe7hZbGIb9H+LL2P YKqzEH3aPJ2rXv5dPWHiTo8TNh8ebkQZ7F8NyevVEaAM7rVPO+Eq7wnNmxDT6OCigomW KNKxF2wc/IJkwrM4yZfapty6nkb9pvqYNu0zoRwBmEqLjKnL/qBd0A8QzJ5LiIk3u7ob RnzP2Qjoyh43xA2JiwDIoVaAUqMH7/Gf+ugfJWcRHQXHLXIr/y5EyO5vhRxLuyQJpZod Muqg== X-Gm-Message-State: AOJu0Yz3+CfZX60Mh5E25e6FyP5sO5WXdPxjnfDYwR0Q5XzG7BkHhTXN 8r82dnBwKnXNFHK9toPISA+zur6c1P8a2VR67/meirgWqsyygKR3TgCcc6vWp7RdQSHz8Q1dGpd aezPODcUkh72vrXLqvzBpCm5b X-Received: by 2002:a17:90b:4b90:b0:27f:fc2f:4831 with SMTP id lr16-20020a17090b4b9000b0027ffc2f4831mr3808823pjb.13.1699848999527; Sun, 12 Nov 2023 20:16:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IExSJF7Sr4fxZ4SaXBfj45m19uu6J8O0+tvnJdz59Xz+72h6hZwy5AtBFfiTF4Ru6jPNTRc+w== X-Received: by 2002:a17:90b:4b90:b0:27f:fc2f:4831 with SMTP id lr16-20020a17090b4b9000b0027ffc2f4831mr3808799pjb.13.1699848999237; Sun, 12 Nov 2023 20:16:39 -0800 (PST) Received: from ?IPV6:2001:8003:e5b0:9f00:b890:3e54:96bb:2a15? ([2001:8003:e5b0:9f00:b890:3e54:96bb:2a15]) by smtp.gmail.com with ESMTPSA id mg5-20020a17090b370500b00282ec3582f1sm2976159pjb.34.2023.11.12.20.16.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Nov 2023 20:16:38 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 14:16:29 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 16/22] x86/topology: use weak version of arch_unregister_cpu() Content-Language: en-US To: "Russell King (Oracle)" , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/23 20:30, Russell King (Oracle) wrote: > Since the x86 version of arch_unregister_cpu() is the same as the weak > version, drop the x86 specific version. > > Signed-off-by: Russell King (Oracle) > --- > Changes since RFC v3: > * Adapt to removal of EXPORT_SYMBOL()s > --- > arch/x86/kernel/topology.c | 5 ----- > 1 file changed, 5 deletions(-) > PATCH[16/22] can be folded to PATCH[15/22] since arch_unregister_cpu() was just added in PATCH[15/22]. Anyway, the changes make sense to me. Reviewed-by: Gavin Shan > diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c > index c2ed3145a93b..211863cb5b81 100644 > --- a/arch/x86/kernel/topology.c > +++ b/arch/x86/kernel/topology.c > @@ -43,9 +43,4 @@ int arch_register_cpu(int cpu) > c->hotpluggable = cpu > 0; > return register_cpu(c, cpu); > } > - > -void arch_unregister_cpu(int num) > -{ > - unregister_cpu(&per_cpu(cpu_devices, num)); > -} > #endif /* CONFIG_HOTPLUG_CPU */