From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF5E34B183 for ; Wed, 20 May 2026 06:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259464; cv=none; b=R6WtnKu0TemnQxhN33JGbObXplVP9CrODufb6ZU6CLfN200fxKyGeqXlb2HA8qY9JGGDO24z2r+pqpvfDQjK0CTdFYRD5YV0Ta2GlguZW6ghdA8UWgwDxxUf8JQXdr93z1+OVaAAqIahasICH61FyAMiplcHba+ruS89K+QVW+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259464; c=relaxed/simple; bh=cyaxZDnfncpfz96qJu+jO+sMOq2b8h0bNELQs9DTTn0=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=UaAxrFWYEs4If3Sq0MSrDmPasN80A/WItcUW77Lggxp0S693fwMGKhJ4DzhE9dznxJ9J9flvrAzzw/byFiqlamDQzz+loJS15Cf3puzpajVjOfYXMPMZ4DIah5zw1NLi2qSvm7UtpibjLrEtkbe66jXpuBEiZjmp+AXCKxjpF4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BZraqWtz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BZraqWtz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94ED81F00894; Wed, 20 May 2026 06:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779259462; bh=/XU1KJEIpJD7sz0WHWX8jsl8435fYv6zL2ltBSoQIW8=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=BZraqWtz+wyZvQfwTXh1uJGtj/eZ6TsmeKA4LFb97yxhx8WntJMqUI82LtycxXxnG YN0krdBBYuZlzA9sG2r1KPD17zGUDC8XB3mze8ZFtwih0h3m7n6BdhM7sL0vL79lbr wkCAZLWl92MOXPYoZhwbkUbkz5F3yD77CA0/9Ot24aRFly1Apl1Es0N/egTJqqNALF rK1AS+o6eCYDVQihrWLOlpWIBGgbYi56FOWy9qa2uUld/Hu0fTTayv+GSSKtG/ubv7 pKzs1fjtvATWPy20FrW2F62guB9DpnoIiUJh8Xn/3LrIjRiQVyAj4LNVk/tX86g+Mf 7/RlApdaEPm5A== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id B46D6F40084; Wed, 20 May 2026 02:44:20 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-01.internal (MEProxy); Wed, 20 May 2026 02:44:20 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddugeefleegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpeefhefgtefgkefhgfdvffdukeejheeuvedthfdtiefhleejhfefjeffieeu jeefteenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrugdomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqudeijedthedttdejledqfeefvdduieegudehqdgrrhgusgeppe hkvghrnhgvlhdrohhrghesfihorhhkohhfrghrugdrtghomhdpnhgspghrtghpthhtohep uddtpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehurdhklhgvihhnvgdqkhhovg hnihhgsegsrgihlhhisghrvgdrtghomhdprhgtphhtthhopegrlhgvgigrnhgurhgvrdgs vghllhhonhhisegsohhothhlihhnrdgtohhmpdhrtghpthhtohepuggrvhgvmhesuggrvh gvmhhlohhfthdrnhgvthdprhgtphhtthhopehhvghrsggvrhhtsehgohhnughorhdrrghp rghnrgdrohhrghdrrghupdhrtghpthhtohepthhhohhrshhtvghnrdgslhhumheslhhinh hugidruggvvhdprhgtphhtthhopehlihhnuhigqdgrrhhmqdhkvghrnhgvlheslhhishht shdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehnihgtohhlrghsrdhfvghrrh gvsehmihgtrhhotghhihhprdgtohhmpdhrtghpthhtoheptghlrghuughiuhdrsggviihn vggrsehtuhigohhnrdguvghvpdhrtghpthhtoheplhhinhhugidqtghrhihpthhosehvgh gvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 8FE65182007E; Wed, 20 May 2026 02:44:20 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 20 May 2026 08:43:59 +0200 From: "Ard Biesheuvel" To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , "Thorsten Blum" , "Herbert Xu" , "David S. Miller" , "Nicolas Ferre" , "Alexandre Belloni" , "Claudiu Beznea" Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20260519141033.1586036-2-u.kleine-koenig@baylibre.com> References: <20260519141033.1586036-2-u.kleine-koenig@baylibre.com> Subject: Re: [PATCH v1] crypto: Use named initializers for struct i2c_device_id Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 19 May 2026, at 16:10, Uwe Kleine-K=C3=B6nig (The Capable Hub) w= rote: > While being less compact, using named initializers allows to more easi= ly > see which members of the structs are assigned which value without havi= ng > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > This patch doesn't modify the compiled arrays, only their representati= on > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) > --- > Hello, > > this patch is part of a bigger quest to use named initializers for > mainly struct i2c_device_id::driver_data to be able to modify > i2c_device_id. See e.g. > https://lore.kernel.org/all/20260518111203.639603-2-u.kleine-koenig@ba= ylibre.com/ > for the details. > > This patch here isn't critical for this quest, as no driver makes use = of > .driver_data, so apart from the better readability this is only about > consistency with other subsystems. > > Best regards > Uwe > > drivers/crypto/atmel-ecc.c | 2 +- > drivers/crypto/atmel-sha204a.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Acked-by: Ard Biesheuvel > diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c > index 9c380351d2f9..56350454ac29 100644 > --- a/drivers/crypto/atmel-ecc.c > +++ b/drivers/crypto/atmel-ecc.c > @@ -380,7 +380,7 @@ MODULE_DEVICE_TABLE(of, atmel_ecc_dt_ids); > #endif >=20 > static const struct i2c_device_id atmel_ecc_id[] =3D { > - { "atecc508a" }, > + { .name =3D "atecc508a" }, > { } > }; > MODULE_DEVICE_TABLE(i2c, atmel_ecc_id); > diff --git a/drivers/crypto/atmel-sha204a.c=20 > b/drivers/crypto/atmel-sha204a.c > index dbb39ed0cea1..0fcb4692494f 100644 > --- a/drivers/crypto/atmel-sha204a.c > +++ b/drivers/crypto/atmel-sha204a.c > @@ -210,8 +210,8 @@ static const struct of_device_id=20 > atmel_sha204a_dt_ids[] __maybe_unused =3D { > MODULE_DEVICE_TABLE(of, atmel_sha204a_dt_ids); >=20 > static const struct i2c_device_id atmel_sha204a_id[] =3D { > - { "atsha204" }, > - { "atsha204a" }, > + { .name =3D "atsha204" }, > + { .name =3D "atsha204a" }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id); > > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > --=20 > 2.47.3