From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755731AbcHZAwr (ORCPT ); Thu, 25 Aug 2016 20:52:47 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:48524 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbcHZAwq (ORCPT ); Thu, 25 Aug 2016 20:52:46 -0400 Subject: Re: [PATCH 2/3] f2fs: schedule in between two continous batch discards To: Jaegeuk Kim References: <1471792891-2388-1-git-send-email-chao@kernel.org> <1471792891-2388-2-git-send-email-chao@kernel.org> <20160823165353.GA73835@jaegeuk> <20160825165716.GA84318@jaegeuk> CC: Chao Yu , , From: Chao Yu Message-ID: Date: Fri, 26 Aug 2016 08:50:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160825165716.GA84318@jaegeuk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0208.57BF926E.0090,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e990998e71eb6eef04dc75ec18a2a3d9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2016/8/26 0:57, Jaegeuk Kim wrote: > Hi Chao, > > On Thu, Aug 25, 2016 at 05:22:29PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/8/24 0:53, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On Sun, Aug 21, 2016 at 11:21:30PM +0800, Chao Yu wrote: >>>> From: Chao Yu >>>> >>>> In batch discard approach of fstrim will grab/release gc_mutex lock >>>> repeatly, it makes contention of the lock becoming more intensive. >>>> >>>> So after one batch discards were issued in checkpoint and the lock >>>> was released, it's better to do schedule() to increase opportunity >>>> of grabbing gc_mutex lock for other competitors. >>>> >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/segment.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >>>> index 020767c..d0f74eb 100644 >>>> --- a/fs/f2fs/segment.c >>>> +++ b/fs/f2fs/segment.c >>>> @@ -1305,6 +1305,8 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) >>>> mutex_unlock(&sbi->gc_mutex); >>>> if (err) >>>> break; >>>> + >>>> + schedule(); >>> >>> Hmm, if other thread is already waiting for gc_mutex, we don't need this here. >>> In order to avoid long latency, wouldn't it be enough to reduce the batch size? >> >> Hmm, when fstrim call mutex_unlock we will pop one blocked locker from FIFO list >> of mutex lock, and wake it up, then fstrimer will try to lock gc_mutex for next >> batch trim, so the popped locker and fstrimer will make a new competition in >> gc_mutex. > > Before trying to grab gc_mutex by fstrim again, there are already blocked tasks > waiting for gc_mutex. Hence the next one should be selectec by FIFO, no? The next one which is going to be waked up is selected by FIFO, but the waked one is still needs to be race with other mutex lock grabber. So there is no such guarantee that the waked one must get the lock. Thanks, > > Thanks, > >> If fstrimer is running in a big core, and popped locker is running in >> a small core, we can't guarantee popped locker can win the race, and for the >> most of time, fstrimer will win. So in order to reduce starvation of other >> gc_mutext locker, it's better to do schedule() here. >> >> Thanks, >> >>> >>> Thanks, >>> >>>> } >>>> out: >>>> range->len = F2FS_BLK_TO_BYTES(cpc.trimmed); >>>> -- >>>> 2.7.2 >>> >>> . >>> > > . >