From: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
To: Arnd Bergmann <arnd@arndb.de>,
Marek Vasut <marek.vasut@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>
Cc: "Joel Stanley" <joel@jms.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Ludovic Barre" <ludovic.barre@st.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] mtd: atmel-quadspi: fix build issues
Date: Tue, 1 Aug 2017 21:41:23 +0200 [thread overview]
Message-ID: <fa857ef2-0ae6-5383-c178-3a86fa557332@wedev4u.fr> (raw)
In-Reply-To: <20170721222204.3402340-1-arnd@arndb.de>
Hi Arnd,
Le 22/07/2017 à 00:21, Arnd Bergmann a écrit :
> I ran into a link-time error with the atmel-quadspi driver on the
> EBSA110 platform:
>
> drivers/mtd/built-in.o: In function `atmel_qspi_run_command':
> :(.text+0x1ee3c): undefined reference to `_memcpy_toio'
> :(.text+0x1ee48): undefined reference to `_memcpy_fromio'
>
> The problem is that _memcpy_toio/_memcpy_fromio are not available
> on that platform, and we have to prevent building the driver there.
>
> A related problem is that the functions are not portable APIs
> and should not be called directly from a device driver. On
> little-endian machines, the regular memcpy_toio/memcpy_fromio
> functions are defined as optimized versions using multi-byte
> transfers that are much faster.
>
> Cyrille mentioned that initially using memcpy_toio/memcpy_fromio
> did not work, but I suspect that this was the result of a bug
> that has since been fixed. With that change, we can also
> compile-test on other architectures.
>
> Link: http://lists.infradead.org/pipermail/linux-mtd/2016-July/068583.html
> Fixes: 161aaab8a067 ("mtd: atmel-quadspi: add driver for Atmel QSPI controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mtd/spi-nor/Kconfig | 2 +-
> drivers/mtd/spi-nor/atmel-quadspi.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index 293c8a4d1e49..22e5fc4080f8 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -41,7 +41,7 @@ config SPI_ASPEED_SMC
>
> config SPI_ATMEL_QUADSPI
> tristate "Atmel Quad SPI Controller"
> - depends on ARCH_AT91 || (ARM && COMPILE_TEST)
> + depends on ARCH_AT91 || (COMPILE_TEST && !ARCH_EBSA110)
> depends on OF && HAS_IOMEM
> help
> This enables support for the Quad SPI controller in master mode.
> diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c b/drivers/mtd/spi-nor/atmel-quadspi.c
> index ba76fa8f2031..ff3849106e77 100644
> --- a/drivers/mtd/spi-nor/atmel-quadspi.c
> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c
> @@ -208,9 +208,9 @@ static int atmel_qspi_run_transfer(struct atmel_qspi *aq,
> if (cmd->enable.bits.address)
> ahb_mem += cmd->address;
> if (cmd->tx_buf)
> - _memcpy_toio(ahb_mem, cmd->tx_buf, cmd->buf_len);
> + memcpy_toio(ahb_mem, cmd->tx_buf, cmd->buf_len);
> else
> - _memcpy_fromio(cmd->rx_buf, ahb_mem, cmd->buf_len);
> + memcpy_fromio(cmd->rx_buf, ahb_mem, cmd->buf_len);
>
At least on AT91 platforms and likely on most ARM boards,
memcpy_fromio == memcpy_toio == memcpy.
I got some sama5d2 hardware last week, so I'll try to test your patch
within few days because as you said maybe memcpy() was broken when I
developed this driver at first but now memcpy() is likely to have been
fixed so it might be interesting to get rid of _memcpy_fromio() and
_memcpy_toio() because this is not the first time those 2 functions have
created issues when building the Atmel Quad SPI driver on other platforms.
So thanks for you're patch, I'll give it a try :)
Best regards,
Cyrille
> return 0;
> }
>
next prev parent reply other threads:[~2017-08-01 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 22:21 Arnd Bergmann
2017-08-01 19:41 ` Cyrille Pitchen [this message]
2017-08-01 20:10 ` Arnd Bergmann
2017-10-13 20:28 ` Cyrille Pitchen
2017-10-16 11:53 ` Arnd Bergmann
2017-10-29 19:49 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa857ef2-0ae6-5383-c178-3a86fa557332@wedev4u.fr \
--to=cyrille.pitchen@wedev4u.fr \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=clg@kaod.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ludovic.barre@st.com \
--cc=marek.vasut@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®