From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52491C43217 for ; Thu, 10 Nov 2022 16:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232516AbiKJQ4a (ORCPT ); Thu, 10 Nov 2022 11:56:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231517AbiKJQ4Y (ORCPT ); Thu, 10 Nov 2022 11:56:24 -0500 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6306B659E for ; Thu, 10 Nov 2022 08:56:23 -0800 (PST) Received: by mail-il1-x12a.google.com with SMTP id x16so1292992ilm.5 for ; Thu, 10 Nov 2022 08:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qH+k4rzdhNlbrn8y8ZyPsEWJ4foiwmUbBpsTlYKcRac=; b=EaUI+pigT02fbHTw9yciXq8LuwjQY/ypAvkQHyTB8iH9PnVixZrpM/uHpMJ4NLAF3K z3SZ3oJ7qtlT9sCr+id+xX33d+hAsETdedAKWMMfPjMBMTi2BQTdQFvU5YqivYOfW7RM 4IlRnpE0vBuQX6TE3mBIuF6IhufOPCZmTZ+g0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qH+k4rzdhNlbrn8y8ZyPsEWJ4foiwmUbBpsTlYKcRac=; b=JikORY5qPevGqfUvOxtK8OiDjYCyyOCnBhUgcjdVeoXaxx6sNefM41L183Cfsd1KkG wDR1mAdHJxt8VDwjyn27ifoBuECHeEn2XIOCs9n7BTyLKVY/iZdFbOXbhC7NEeSuBbOF FdrHMUrcS2VXHWnKWvcdy4agLXO4hoV8BGglfjeanm+tKI5N0Bbt/jEogb++ClO0l1RW YmR9k9+e/glIlIKcpYUs8CSRa56BqAJRAjDHVgCP8aB9lsdEW2u6rVBzBihCy/pwsBzo M3SJyAz0HOkWHiszUqxLZJu1UY7C5exycq2fdokwIsbXMxCGPVpPIMA8fxJRlOSr5HFc qkdA== X-Gm-Message-State: ACrzQf3QQl6satLJp3TKdvjiAjA3hYcjrUdkEJwxhRzO2UHIDyFrb14C JRVI1auWXUiJ8UFVi/mG1F9evg== X-Google-Smtp-Source: AMsMyM7IRyqqc+gKMsu1cERbqLg9VMIzbAQVa4Gj7NZAdOjBsJ+9S0q61JPSlsVAv/mPauXuH2+g7A== X-Received: by 2002:a92:6e0b:0:b0:300:716a:2705 with SMTP id j11-20020a926e0b000000b00300716a2705mr2998846ilc.217.1668099382697; Thu, 10 Nov 2022 08:56:22 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id x10-20020a02340a000000b00349d2d52f6asm5793163jae.37.2022.11.10.08.56.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 08:56:22 -0800 (PST) Message-ID: Date: Thu, 10 Nov 2022 09:56:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] media: vimc: Fix wrong function called when vimc_init() fails Content-Language: en-US To: Chen Zhongjin , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hans.verkuil@cisco.com, helen.koike@collabora.com, Shuah Khan References: <20221110072633.210437-1-chenzhongjin@huawei.com> From: Shuah Khan In-Reply-To: <20221110072633.210437-1-chenzhongjin@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/22 00:26, Chen Zhongjin wrote: > In vimc_init(), when platform_driver_register(&vimc_pdrv) fails, > platform_driver_unregister(&vimc_pdrv) is wrongly called rather than > platform_device_unregister(&vimc_pdev), which causes kernel warning: > > Unexpected driver unregister! > WARNING: CPU: 1 PID: 14517 at drivers/base/driver.c:270 driver_unregister+0x8f/0xb0 > RIP: 0010:driver_unregister+0x8f/0xb0 > Call Trace: > > vimc_init+0x7d/0x1000 [vimc] > do_one_initcall+0xd0/0x4e0 > do_init_module+0x1cf/0x6b0 > load_module+0x65c2/0x7820 > > Fixes: 4a29b7090749 ("[media] vimc: Subdevices as modules") > Signed-off-by: Chen Zhongjin > --- > drivers/media/test-drivers/vimc/vimc-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c > index 2ae7a0f11ebf..e82cfa5ffbf4 100644 > --- a/drivers/media/test-drivers/vimc/vimc-core.c > +++ b/drivers/media/test-drivers/vimc/vimc-core.c > @@ -433,7 +433,7 @@ static int __init vimc_init(void) > if (ret) { > dev_err(&vimc_pdev.dev, > "platform driver registration failed (err=%d)\n", ret); > - platform_driver_unregister(&vimc_pdrv); > + platform_device_unregister(&vimc_pdev); > return ret; > } > Good catch. Thanks for fixing it. Now applied for next rc. https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/?h=vimc thanks, -- Shuah