From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BCB38A71C for ; Tue, 20 Jan 2026 09:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900139; cv=none; b=drHW5tJiwgqqID18RWUjZaMknY144Q+dNvD/tWGGqd/pFxf8Fe75T6tY7TtlSaUkrXVC27+4Xhwk54Th5YjIcwmznEdYzu0sK7LDYYpGIDpV0SrEqpTkQEQUYFDqfwpUVqJW45u1HWsJMA51lNBkwFtmQkrrWQSphfmcnI0gjfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900139; c=relaxed/simple; bh=k+acc+Blsz7PjSI0EXgf2vzztKO1vh4z8hxzeh31Vv0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=EPLRLnTv34lizfLSMuasllgN6V9w0mb/u8fADCBxcZQ13JEZ5N9t6He98RguSRZ3mwjAxoM/d6rfTtaZHzO1V8sZJmYy63tGoTcIO5mdej1rQY+9XDkg+C25KFH3slW/n4B2RG1ZvXIjssVIflct9dH4VZJV5oYDlMpTE9Rwd3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z6zndvWj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=EmUyTO8L; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z6zndvWj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="EmUyTO8L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768900136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k+acc+Blsz7PjSI0EXgf2vzztKO1vh4z8hxzeh31Vv0=; b=Z6zndvWjAWD2VN5k41uE1WUH3gd1YZrWuL7rNHlfDsf9VB9UKOQ1Kz9ZRW9ZcCogjZXoCN pMMYfLB3xQuNnP+QzwxwxQTfjE2Ry6FxZbrYceFBprI8inN9+R0XFy+Ez9rnBO9zei7niE U4bDqmo3a7Gb29MDQuUsuTSTg/S467g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-PrOXDe67MwOt1rxH7ZxWDw-1; Tue, 20 Jan 2026 04:08:55 -0500 X-MC-Unique: PrOXDe67MwOt1rxH7ZxWDw-1 X-Mimecast-MFC-AGG-ID: PrOXDe67MwOt1rxH7ZxWDw_1768900134 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4325b81081aso4242183f8f.3 for ; Tue, 20 Jan 2026 01:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768900134; x=1769504934; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=k+acc+Blsz7PjSI0EXgf2vzztKO1vh4z8hxzeh31Vv0=; b=EmUyTO8L8trjLaTizMLqoQnm0Llna5aV10oWFwZisVixdlR5RdDxsEukQfWK9zoudW a3qvijpm5rNn6gjSvcBRMGDCSRbf1OnbF3nrAHleArfN+8liG4Q4B7pdYuoBPcYEKZJ7 gbgEnrfGdSDFpDqk8NFDlSG1qZdCu/HRSznD/dJiVNR+S+gWlA5ZnVgLyL4Y2/rJMPAs sUaXx7gag5lXiRkMl6a4aZkJHeU90ETU16+Bh0NBJSkToOArnHsEKr1WPhP1onLhlK/Q D7LOiZVnlRcTFZ+isa/BYVmmWmoc9y5DT7o1oMZepoGS2xzweqURbnLNQ8BgFozC0+8V 83ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900134; x=1769504934; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k+acc+Blsz7PjSI0EXgf2vzztKO1vh4z8hxzeh31Vv0=; b=wGMbzmRtw62P3/QHVacM1jlBY/DMDgLFDlKKRbG5/nV/j6bEV+5lqZFjLNZph0o82o vrfynG6c+PGz0OyVYUmV7umKoi+UAEttCspThQWpNvsYd1CuBmQ0go/XS9IYL+i/zir/ qZdF/eEkBLD5KmoS6ftmewWbu3M1G8uNmPeKUlhHKAWnF85yaDGn0VKpiz70yzLVnQjv Vze55K0D5Z6vhDCOC5Ev83zHKkSn7TOP63bjngKyzx6bvZ6+QKMtB51pnOHyl5ja5H5d F/FxXe20gD8RWoaseocknrFKrShFcfHXjdnyKr0XYmPUTEp6LixVFbglivrYBThRkI3W I9+A== X-Forwarded-Encrypted: i=1; AJvYcCXvnvPxI2yJrPXqH4lfOgapuGAPyJ3gIAKXobybblA0n1stwVJxO423+O5Qkljon+s79jMsjHSBBKvD97Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzXDMIiQ/HTsStHbYjj7cbJ4OKpwuKLWn5178J+Guvfu4HD1/Lf nUS++2st30hEo8dlPj/3ipTPTRC3mhouuDpc8OyEkG+IhpioQKSC0LXUsOj1LgsObgofCz2KRcW HMQXd3ZZ9o1Fx76sgfHRZ38SWzSIyspRoKfPmCluhVZfWhnxhcGUvGiWEJck2g41qTA== X-Gm-Gg: AZuq6aJrsMet+T1F94cFWHvy/8BpT0Wq6b4anGX8PtAtUW4wXOcp8gTDwYA83WIZHL+ PGsH7N/6QdNsIFxDtvBY/hYJzNPPXYJTTezRFCFeeEi+G7Ws4G2PmJG2VWkPtykmSJg6NHCVXqF PwD3lqRotlJC2d+eIMsXWOv5BdPlMfgyiUDKk1BHsR/mIYY9Ju3PIOa/lVo70DHw46JlDFNH1iY 43hA0pY7j2Y+kh3d5Z0HpKkmdHYg/+nJWdsfgLYxoIWiwUyIZeQOr953N0ISxXrajVtI3HjMCdC S5S9EMD+yQ7nSkHsegW9qTmxH+69FnTIhyBkZDLvzHVGMTT7EQFo0DM0HMpeeupvYpMUn96Vwtu ZV5LXv95gv0WrIsAPlBfG+JyxGtMrXjD2H0OfSVd8vojPONvxgVqGQVRdgwiyebxaDOJshofW+Z iDyikH0I78 X-Received: by 2002:a05:6000:208a:b0:430:fd0f:2910 with SMTP id ffacd0b85a97d-4358fed868dmr2010168f8f.26.1768900133733; Tue, 20 Jan 2026 01:08:53 -0800 (PST) X-Received: by 2002:a05:6000:208a:b0:430:fd0f:2910 with SMTP id ffacd0b85a97d-4358fed868dmr2010121f8f.26.1768900133287; Tue, 20 Jan 2026 01:08:53 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356992201csm29032387f8f.2.2026.01.20.01.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:08:53 -0800 (PST) Message-ID: Subject: Re: [PATCH 22/26] rv/rvgen: remove unused __get_main_name method From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 10:08:51 +0100 In-Reply-To: <20260119205601.105821-23-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-23-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > The __get_main_name() method in the generator module is never called > from anywhere in the codebase. Remove this dead code to improve > maintainability. >=20 > Signed-off-by: Wander Lairson Costa Good catch, thanks! Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/rvgen/generator.py | 6 ------ > =C2=A01 file changed, 6 deletions(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/generator.py > b/tools/verification/rvgen/rvgen/generator.py > index 0491f8c9cb0b9..d99a980850d64 100644 > --- a/tools/verification/rvgen/rvgen/generator.py > +++ b/tools/verification/rvgen/rvgen/generator.py > @@ -206,12 +206,6 @@ obj-$(CONFIG_RV_MON_{name_up}) +=3D > monitors/{name}/{name}.o > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = path =3D os.path.join(self.rv_dir, "monitors", path) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.__write_file(path, = content) > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def __get_main_name(self): > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 path =3D f"{self.name}/main.c= " > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if not os.path.exists(path): > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 retur= n "main.c" > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "__main.c" > - > =C2=A0=C2=A0=C2=A0=C2=A0 def print_files(self): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 main_c =3D self.fill_mai= n_c() > =C2=A0