mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, fenghua.yu@intel.com, vkoul@kernel.org,
	dave.jiang@intel.com, tony.luck@intel.com,
	wajdi.k.feghali@intel.com, james.guilford@intel.com,
	kanchana.p.sridhar@intel.com, giovanni.cabiddu@intel.com,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v5 13/15] crypto: iaa - Add support for default IAA 'canned' compression mode
Date: Wed, 24 May 2023 10:58:54 -0500	[thread overview]
Message-ID: <fa90e73483b866a0622ad077f4af16978d1c1c8d.camel@linux.intel.com> (raw)
In-Reply-To: <ZG3dpbPlRXbF2ZxN@gondor.apana.org.au>

Hi Herbert,

On Wed, 2023-05-24 at 17:49 +0800, Herbert Xu wrote:
> On Tue, May 16, 2023 at 04:50:07PM -0500, Tom Zanussi wrote:
> .
> > To choose 'fixed' mode:
> > 
> >   echo "fixed" >  /sys/bus/dsa/drivers/crypto/compression_mode
> > 
> > To choose 'canned' mode:
> > 
> >   echo "canned" >  /sys/bus/dsa/drivers/crypto/compression_mode
> 
> This seems to be a strange way to switch modes.  How about just
> registering both algorithms and then let the user decide which
> one to use throught the algorithm name?
> 

Yes, I think you're right.  The reason we did it this way was that
we're expecting to add more modes, such as 'dynamic' and/or 'canned-
dynamic' etc.

But I don't see a reason we couldn't just register them all and have
the user choose using the algorithm names, especially if that's the way
crypto users expect things to work.

Thanks,

Tom 



  reply	other threads:[~2023-05-24 16:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 21:49 [PATCH v5 00/15] crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver Tom Zanussi
2023-05-16 21:49 ` [PATCH v5 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool Tom Zanussi
2023-05-16 21:49 ` [PATCH v5 02/15] dmaengine: idxd: add external module driver support for dsa_bus_type Tom Zanussi
2023-05-16 21:49 ` [PATCH v5 03/15] dmaengine: idxd: Export drv_enable/disable and related functions Tom Zanussi
2023-05-16 21:49 ` [PATCH v5 04/15] dmaengine: idxd: Export descriptor management functions Tom Zanussi
2023-05-16 21:49 ` [PATCH v5 05/15] dmaengine: idxd: Export wq resource " Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 06/15] dmaengine: idxd: Add wq private data accessors Tom Zanussi
2023-05-16 21:57   ` Dave Jiang
2023-05-16 21:50 ` [PATCH v5 07/15] dmaengine: idxd: add callback support for iaa crypto Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 08/15] crypto: iaa - Add IAA Compression Accelerator Documentation Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 09/15] crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 10/15] crypto: iaa - Add per-cpu workqueue table with rebalancing Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 11/15] crypto: iaa - Add compression mode management along with fixed mode Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 12/15] crypto: iaa - Add support for iaa_crypto deflate compression algorithm Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 13/15] crypto: iaa - Add support for default IAA 'canned' compression mode Tom Zanussi
2023-05-24  9:49   ` Herbert Xu
2023-05-24 15:58     ` Tom Zanussi [this message]
2023-05-25  0:37       ` Herbert Xu
2023-05-30 19:50         ` Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 14/15] crypto: iaa - Add irq support for the crypto async interface Tom Zanussi
2023-05-16 21:50 ` [PATCH v5 15/15] crypto: iaa - Add IAA Compression Accelerator stats Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa90e73483b866a0622ad077f4af16978d1c1c8d.camel@linux.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=james.guilford@intel.com \
    --cc=kanchana.p.sridhar@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    --cc=wajdi.k.feghali@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome