From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B76361AE003 for ; Mon, 14 Oct 2024 15:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728919663; cv=none; b=S218S6IAXFcJ8yQLr00IxKlZPxrAymt1KJsC582QQCaTo8BneLViSUtj60+yrwYv0+iGtAusUpVM+ByMht2QPfEV5PbEg6mkXzXgBe9oZbshVC/OA8vaIIp2la8L5iHfv/bdlGCrD497LYOcAxlgOrZsLMG8yZ7yjUsrzgQpmgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728919663; c=relaxed/simple; bh=0H6/2eoMwH/tdX7EhGLtY7HdvCmRkYRIKrU4DrTa0jo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YPyfgXBingeV3FlyR67wHdvy/j3a78FHKiFMn331x0XjPFA+w2cih32thQ9HDfbOtr7rklYr4D1fUaG2L4Zbz7Mt1Vg8maa6MELMSfCVBuScbAS8ZGlb/B3eYFWX8HRAJCBIlh05IStW95+Y8HSXfygqqMJck/e1W7uwZv7ik0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DcxyHjAv; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DcxyHjAv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728919662; x=1760455662; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0H6/2eoMwH/tdX7EhGLtY7HdvCmRkYRIKrU4DrTa0jo=; b=DcxyHjAvaz3n3VKPkc4rH7EWtdHVJSSyS+s1OgwzyP+9v/W5YR5CHHV6 qOOPSkooC2z1V6DRudwLIOfZRM4B4ykz7QX6oRWpS7H76JTIowdV9BuS6 o14ebEoDJX+0fy5VAy39VMLBfkAFRFpJhdVqZ2b1JX+ykN8Z8qrMNhCMC 71ztnlbyE5zjuhG3hkNA2iYs9LA1iCY1obgm60Z0QM9FeT4pyS+C8ZbpT wZbCl5asy3HA2GQ5yzAIO2+XiMiiFEnY2kBZFXRgq1Z9rr6cWepEb4wjN T0AqklXjYP1pEsCtBb/RTeHJjxsozUxoV38e4s7LYeo53aMTfyIhxBR5+ A==; X-CSE-ConnectionGUID: L/7tenToQWSG+Pu/7dp6dg== X-CSE-MsgGUID: WbcHmieCSa6uduICdYSHrg== X-IronPort-AV: E=McAfee;i="6700,10204,11224"; a="38851687" X-IronPort-AV: E=Sophos;i="6.11,203,1725346800"; d="scan'208";a="38851687" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 08:27:41 -0700 X-CSE-ConnectionGUID: i5CqxEqmTQ2Y20P+yOg4AA== X-CSE-MsgGUID: qErxVOBHRxizkwMQ8Tc8nQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,203,1725346800"; d="scan'208";a="108351335" Received: from mdroper-mobl2.amr.corp.intel.com (HELO [10.124.220.235]) ([10.124.220.235]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 08:27:38 -0700 Message-ID: Date: Mon, 14 Oct 2024 08:27:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [x86/module] 6661cae1aa: WARNING:at_arch/x86/mm/pat/set_memory.c:#__cpa_process_fault To: Mike Rapoport Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Christoph Hellwig , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , linux-kernel@vger.kernel.org References: <202410111408.8fe6f604-lkp@intel.com> <73d5a6ed-da3c-448e-8cf8-6abb59cb2c36@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/13/24 01:17, Mike Rapoport wrote: > On Fri, Oct 11, 2024 at 09:30:33AM -0700, Dave Hansen wrote: >> On 10/11/24 08:40, Mike Rapoport wrote: >>> On Fri, Oct 11, 2024 at 07:00:01AM -0700, Dave Hansen wrote: >>>> On 10/11/24 06:08, Mike Rapoport wrote: >>>>> This patch disables ROX caches on 32-bit, it should fix the issue. >>>> While I'm not going to shed a tear for 32-bit, what's the actual >>>> compatibility issue with 32-bit? >>> From the stack trace it looks like execmem tries to update the direct map >>> for highmem memory, and cpa is not happy about it. >> >> First of all, if it's a highmem problem, shouldn't the check be for >> CONFIG_HIGHMEM and not on 32-bit vs. 64-bit? We do have non-highmem >> 32-bit configs. > > 32 bit also does not have ARCH_HUGE_VMALLOC and execmem cache will be > anyway populated with 4k pages, so I don't see why it would be useful on 32 > bit all. It's not really about making it _available_ to 32-bit, but making sure that we're actually doing the check against the right feature and in the right way. To me, it seems like execmem itself should be excluding all HIGHMEM=y builds or _maybe_ all 32-bit builds because execmem has the built-in assumption that vmalloc memory is in the direct map. That seems preferable to sticking a 32-bit (or highmem) check in all the architectures. This code: > +static int execmem_set_direct_map_valid(struct vm_struct *vm, bool valid) > +{ > + unsigned int nr = (1 << get_vm_area_page_order(vm)); > + unsigned int updated = 0; > + int err = 0; > + > + for (int i = 0; i < vm->nr_pages; i += nr) { > + err = set_direct_map_valid_noflush(vm->pages[i], nr, valid); seems arguably buggy (or at least potentially fragile) since it implicitly assumes that vmalloc'd memory has a spot in the direct map. The "this architecture and config has a direct map for all pages" assumption is not clear here at all. >> Also, where did the highmem come from? All of the execmem allocations >> look like they're some variant of PAGE_KERNEL, but no __GFP_HIGHMEM. > > Despite that execmem allocations are PAGE_KERNEL, __vmalloc_area_node() > implicitly adds __GFP_HIGHMEM for !DMA allocations. Ahh, I missed that bit. Thanks for the explanation.