From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbcHNTJl (ORCPT ); Sun, 14 Aug 2016 15:09:41 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42312 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbcHNTJk (ORCPT ); Sun, 14 Aug 2016 15:09:40 -0400 Subject: Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments" To: Jonathan Corbet , Joe Perches References: <9a191e42dbdfaff2835f5f815fd5413815bba0fd.1468369072.git.joe@perches.com> <1470333314.3998.245.camel@perches.com> <20160814123523.26ae4b40@lwn.net> Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org From: Randy Dunlap Message-ID: Date: Sun, 14 Aug 2016 12:09:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160814123523.26ae4b40@lwn.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/16 11:35, Jonathan Corbet wrote: > On Thu, 04 Aug 2016 10:55:14 -0700 > Joe Perches wrote: > >>> Because Linus may still be reading source code on greenbar paper >>> instead of color terminals with code syntax highlighting and >>> appropriate font decorations. >>> >>> Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com >>> >>> Signed-off-by: Joe Perches >>> --- >>> Documentation/CodingStyle | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle >>> index 9a70ddd..19b2e9c 100644 >>> --- a/Documentation/CodingStyle >>> +++ b/Documentation/CodingStyle >>> @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format. >>> See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc >>> for details. >>> >>> -Linux style for comments is the C89 "/* ... */" style. >>> -Don't use C99-style "// ..." comments. >>> - >>> The preferred style for long (multi-line) comments is: >>> >>> /* >> >> ping? > > Sorry, I've not been ignoring this, I've just not yet worked up the > courage to apply it. Yes, Linus said he's fine with C++-style comments, > but I still expect some pushback when people start actually sending them. > I don't quite feel a sense of community consensus on this one. > > Still, what the heck, I'll go ahead and apply it. We can always revert it > when people start screaming :) I like it, but like Linus said, we don't want people to send patches just to "fix" the comment style. -- ~Randy