From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
<cassiogabrielcontato@gmail.com>,
Haotian Zhang <vulab@iscas.ac.cn>,
Christian Marangi <ansuelsmth@gmail.com>,
Cyril Chao <Cyril.Chao@mediatek.com>, Tuo Li <islituo@gmail.com>,
Rosen Penev <rosenp@gmail.com>,
Garlic Tseng <garlic.tseng@mediatek.com>,
"Alexandre Mergnat" <amergnat@baylibre.com>,
Dan Carpenter <error27@gmail.com>, <linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Mark Brown" <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Trevor Wu <trevor.wu@mediatek.com>
Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8189:return 0 from mt8189_fe_startup() on success
Date: Tue, 6 Oct 2026 12:44:09 +0200 [thread overview]
Message-ID: <fa9642c4-7117-4d34-928b-f0937becc593@intel.com> (raw)
In-Reply-To: <20261006101606.54079-4-phucduc.bui@gmail.com>
On 10/6/2026 12:16 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> snd_pcm_hw_constraint_integer() may return 1, which is then returned
> from mt8189_fe_startup(). ASoC only treats 0 as success when marking
> the DAI as started, so .shutdown() can be skipped on rollback.
Nothing major here, just the missing space between 'mt8189:return' in
the title.
IMHO the title could be made more explicit as you're in fact fixing how
the snd_pcm_hw_constraint_xxx() is handled by the driver. "Return 0 from
(...)" misses the point.
Kind regards,
Czarek
next prev parent reply other threads:[~2026-10-06 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 10:16 [PATCH 0/4] ASoC: mediatek: Return 0 from FE startup " phucduc.bui
2026-10-06 10:16 ` [PATCH 1/4] ASoC: mediatek: common: return 0 from mtk_afe_fe_startup() " phucduc.bui
2026-10-06 10:16 ` [PATCH 2/4] ASoC: mediatek: mt8188: return 0 from mt8188_afe_fe_startup() " phucduc.bui
2026-10-06 10:39 ` Cezary Rojewski
2026-10-06 11:09 ` Bui Duc Phuc
2026-10-06 10:16 ` [PATCH 3/4] ASoC: mediatek: mt8189:return 0 from mt8189_fe_startup() " phucduc.bui
2026-10-06 10:44 ` Cezary Rojewski [this message]
2026-10-06 11:18 ` Bui Duc Phuc
2026-10-06 10:16 ` [PATCH 4/4] ASoC: mediatek: mt8365: return 0 from mt8365_afe_fe_startup() " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9642c4-7117-4d34-928b-f0937becc593@intel.com \
--to=cezary.rojewski@intel.com \
--cc=Cyril.Chao@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=error27@gmail.com \
--cc=garlic.tseng@mediatek.com \
--cc=islituo@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®