From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294AbdEIDfp (ORCPT ); Mon, 8 May 2017 23:35:45 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:38064 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbdEIDfn (ORCPT ); Mon, 8 May 2017 23:35:43 -0400 Subject: Re: [PATCH] thermal: core: make thermal_emergency_poweroff static To: Colin King , Zhang Rui , Eduardo Valentin , References: <20170508103643.10748-1-colin.king@canonical.com> CC: , From: Keerthy Message-ID: Date: Tue, 9 May 2017 09:05:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170508103643.10748-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 May 2017 04:06 PM, Colin King wrote: > From: Colin Ian King > > Making thermal_emergency_poweroff static fixes sparse warning: > > drivers/thermal/thermal_core.c:6: warning: symbol > 'thermal_emergency_poweroff' was not declared. Should it be static? Acked-by: Keerthy > > Fixes: ef1d87e06ab4 ("thermal: core: Add a back up thermal shutdown mechanism") > Signed-off-by: Colin Ian King > --- > drivers/thermal/thermal_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index b21b9cc2c8d6..5a51c740e372 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -359,7 +359,7 @@ static DECLARE_DELAYED_WORK(thermal_emergency_poweroff_work, > * This may be called from any critical situation to trigger a system shutdown > * after a known period of time. By default this is not scheduled. > */ > -void thermal_emergency_poweroff(void) > +static void thermal_emergency_poweroff(void) > { > int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS; > /* >