From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Haotian Zhang <vulab@iscas.ac.cn>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: ralink: Fix resource leaks in init error path
Date: Wed, 5 Nov 2025 14:39:03 +0100 [thread overview]
Message-ID: <fa9884d8-fa2b-4f8b-8fb0-97f4a276c9c4@linaro.org> (raw)
In-Reply-To: <20251030090710.1603-1-vulab@iscas.ac.cn>
On 10/30/25 10:07, Haotian Zhang wrote:
> The ralink_systick_init() function does not release all acquired resources
> on its error paths. If irq_of_parse_and_map() or a subsequent call fails,
> the previously created I/O memory mapping and IRQ mapping are leaked.
>
> Add goto-based error handling labels to ensure that all allocated
> resources are correctly freed.
>
> Fixes: 1f2acc5a8a0a ("MIPS: ralink: Add support for systick timer found on newer ralink SoC")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2025-11-05 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 9:07 Haotian Zhang
2025-11-05 13:39 ` Daniel Lezcano [this message]
2025-11-26 14:40 ` [tip: timers/clocksource] clocksource/drivers/ralink: " tip-bot2 for Haotian Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9884d8-fa2b-4f8b-8fb0-97f4a276c9c4@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®