From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D2EC433EF for ; Tue, 1 Mar 2022 01:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbiCABrl (ORCPT ); Mon, 28 Feb 2022 20:47:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbiCABrk (ORCPT ); Mon, 28 Feb 2022 20:47:40 -0500 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B51184 for ; Mon, 28 Feb 2022 17:46:58 -0800 (PST) X-UUID: 6f33e31bd00749f998d87b09d184cfc6-20220301 X-UUID: 6f33e31bd00749f998d87b09d184cfc6-20220301 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1245295757; Tue, 01 Mar 2022 09:46:43 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Tue, 1 Mar 2022 09:46:42 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 1 Mar 2022 09:46:42 +0800 Message-ID: Subject: Re: [PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev From: Jason-JH Lin To: Chun-Kuang Hu CC: Philipp Zabel , Matthias Brugger , , David Airlie , Daniel Vetter , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel , Hsin-Yi Wang , "Fei Shao" , Nancy Lin , Date: Tue, 1 Mar 2022 09:46:42 +0800 In-Reply-To: References: <20211202064039.20797-1-jason-jh.lin@mediatek.com> <20211202064039.20797-3-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chun-Kuang, Thanks for the reviews. I forgot to add the comment that the patch should be based on [1]. We can only apply it after applying [1]. So please apply it after that. Thank you very much! Regards, Jason-JH.Lin --- [1] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support https://patchwork.kernel.org/project/linux-mediatek/patch/20220222100741.30138-21-nancy.lin@mediatek.com/ --- On Sun, 2022-02-27 at 11:33 +0800, Chun-Kuang Hu wrote: > Hi, Jason: > > Build error: > > ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c: In function > ‘mtk_drm_crtc_create’: > ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:902:26: error: ‘struct > mtk_drm_private’ has no member named ‘dev’ > mtk_crtc->drm_dev = priv->dev; > ^ > ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:974:30: error: ‘struct > mtk_drm_private’ has no member named ‘dev’ > link = device_link_add(priv->dev, mtk_crtc->cmdq_client.chan- > >mbox->dev, > ^ > In file included from ../include/linux/device.h:15:0, > from ../include/linux/dma-mapping.h:7, > from ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:7: > ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:977:16: error: ‘struct > mtk_drm_private’ has no member named ‘dev’ > dev_err(priv->dev, "Unable to link dev=%s\n", > ^ > Regards, > Chun-Kuang.