From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759069AbdAKCaU (ORCPT ); Tue, 10 Jan 2017 21:30:20 -0500 Received: from mga05.intel.com ([192.55.52.43]:2086 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757030AbdAKCaS (ORCPT ); Tue, 10 Jan 2017 21:30:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="1081574408" Subject: Re: [PATCH] scsi: remove useless acpi functions in the head file To: Hanjun Guo References: <1484036044-9514-1-git-send-email-guohanjun@huawei.com> <2e748ead-9118-9a00-d9e7-711fc2cd85c3@intel.com> <58759557.7060405@huawei.com> Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, John Garry , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hanjun Guo From: Aaron Lu Message-ID: Date: Wed, 11 Jan 2017 10:30:15 +0800 MIME-Version: 1.0 In-Reply-To: <58759557.7060405@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 10:15 AM, Hanjun Guo wrote: > On 2017/1/11 9:50, Aaron Lu wrote: >> On 01/10/2017 07:44 PM, John Garry wrote: >>> On 10/01/2017 08:14, Hanjun Guo wrote: >>>> From: Hanjun Guo >>>> >>>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support") >>>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(), >>>> but forgot to remove them in the head file, do it now. >>>> >>>> Signed-off-by: Hanjun Guo >> Reviewed-by: Aaron Lu >> >> Just out of curiosity, did you find this by some tool? If so, can you >> please let me know the tool name so that I can avoid such problems in >> the future? Thanks. > > No, not found by tool. I was working on a patch set which tried to > introduce a new acpi bus type [1], so I greped the usage of > "struct acpi_bus_type" then found this issue :) I see, thanks for the cleanup. Regards, Aaron