From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CADFC55199 for ; Sun, 26 Apr 2020 10:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 190A82070A for ; Sun, 26 Apr 2020 10:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726154AbgDZKdJ (ORCPT ); Sun, 26 Apr 2020 06:33:09 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3306 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726117AbgDZKdJ (ORCPT ); Sun, 26 Apr 2020 06:33:09 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 760C4A8980FC7A72735A; Sun, 26 Apr 2020 18:33:07 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Sun, 26 Apr 2020 18:33:04 +0800 Subject: Re: [PATCH] ray_cs: use true,false for bool variable From: Jason Yan To: Sergei Shtylyov , , , , , , , References: <20200426094103.23213-1-yanaijie@huawei.com> <9c67aee9-ece6-01f0-895a-e690b967d819@cogentembedded.com> <0b7407e4-c7ad-f97b-0050-9086f245c6cc@huawei.com> Message-ID: Date: Sun, 26 Apr 2020 18:33:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <0b7407e4-c7ad-f97b-0050-9086f245c6cc@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/4/26 18:27, Jason Yan 写道: > > > 在 2020/4/26 17:47, Sergei Shtylyov 写道: >> Hello! >> >> On 26.04.2020 12:41, Jason Yan wrote: >> >>> Fix the following coccicheck warning: >>> >>> drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to >>> bool variable >>> drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to >>> bool variable >>> >>> Signed-off-by: Jason Yan >>> --- >>>   drivers/net/wireless/ray_cs.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ray_cs.c >>> b/drivers/net/wireless/ray_cs.c >>> index c1d542bfa530..f9402424accd 100644 >>> --- a/drivers/net/wireless/ray_cs.c >>> +++ b/drivers/net/wireless/ray_cs.c >>> @@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void) >>>       proc_create_data("driver/ray_cs/translate", 0200, NULL, >>> &int_proc_ops, >>>                &translate); >>>   #endif >>> -    if (translate != 0) >>> -        translate = 1; >>> +    if (!translate) >> >>     That inverts the original logic, no? > > Oh, yes. > >> >>> +        translate = true; >> >>     Actually, that whole comparison/assignment doesn't make sense, if >> we use bool... >> > > So may be we can do this: > > diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c > index c1d542bfa530..9ea695459342 100644 > --- a/drivers/net/wireless/ray_cs.c > +++ b/drivers/net/wireless/ray_cs.c > @@ -2794,8 +2794,7 @@ static int __init init_ray_cs(void) >         proc_create_data("driver/ray_cs/translate", 0200, NULL, > &int_proc_ops, >                          &translate); >  #endif > -       if (translate != 0) > -               translate = 1; > +       translate == !!translate; Sorry, this should be: translate = !!translate; >         return 0; >  } /* init_ray_cs */ > >> [...] >> >> MBR, Sergei >> >> . > > > .