From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E09C04A6A for ; Fri, 4 Aug 2023 02:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbjHDC7d (ORCPT ); Thu, 3 Aug 2023 22:59:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232716AbjHDC73 (ORCPT ); Thu, 3 Aug 2023 22:59:29 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 631584220; Thu, 3 Aug 2023 19:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691117963; x=1722653963; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=YyNSAAHZUlGA/Nj8JDQMCImBLWmGgqOE3kwnXdtnCok=; b=BHibTff8qto2+0u8mV++5eT4kRgyhJJrUVfCWU+/6dE8mA0orlVmIPCq 86DH0lGnkhDgi1EAgCIwxXNH85r3FZ/EYPjwuIjArBRvGCmLt+kHI4no6 TTuXu8ONY2w+JlJ39jYSQ9VaWqw80baKYJg4+5UY65BuNTw43o9Vvluk5 tsT+YHH3mGeNc5oWAOFvn4ifQ5CdV6WIc3y/c2qn+/WexpOaGp4N2SRq3 1r1/7aM67sMOqKgc/uzfmcgDcLwQTIbF83ufhZBBzEYPlwfeoP4tactOr HnCuohL3Zy+a7TXPR0efPrDVrU8k/UJXLlEKp6CHLhRCgT0fvnd5lheVa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="373694109" X-IronPort-AV: E=Sophos;i="6.01,253,1684825200"; d="scan'208";a="373694109" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 19:59:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="1060543668" X-IronPort-AV: E=Sophos;i="6.01,253,1684825200"; d="scan'208";a="1060543668" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.210.88]) ([10.254.210.88]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 19:59:02 -0700 Message-ID: Date: Fri, 4 Aug 2023 10:58:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: baolu.lu@linux.intel.com, "Liu, Yi L" , Jacob Pan , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/12] iommu: Remove unrecoverable fault data Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Jean-Philippe Brucker , Nicolin Chen References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-4-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/3 15:54, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Thursday, July 27, 2023 1:48 PM >> >> struct iommu_fault { >> __u32 type; >> - __u32 padding; > this padding should be kept. > To keep above 64-bit aligned, right? I can't think of any other reason to keep it. Best regards, baolu