From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbcHPGQG (ORCPT ); Tue, 16 Aug 2016 02:16:06 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:34330 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753159AbcHPGQE (ORCPT ); Tue, 16 Aug 2016 02:16:04 -0400 Subject: Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument. To: Thiago Jung Bauermann References: <1470956898-5991-1-git-send-email-bauerman@linux.vnet.ibm.com> <1470956898-5991-3-git-send-email-bauerman@linux.vnet.ibm.com> <20160815073049.GB21080@balbir.ozlabs.ibm.com> <1906561.y8blzB2uZ8@hactar> Cc: kexec@lists.infradead.org, Stewart Smith , Baoquan He , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Ingo Molnar , Paul Mackerras , Eric Biederman , Thomas Gleixner , Dave Young , Andrew Morton , Vivek Goyal From: Balbir Singh Message-ID: Date: Tue, 16 Aug 2016 16:15:55 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1906561.y8blzB2uZ8@hactar> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/16 00:49, Thiago Jung Bauermann wrote: > Am Montag, 15 August 2016, 17:30:49 schrieb Balbir Singh: >> On Thu, Aug 11, 2016 at 08:08:07PM -0300, Thiago Jung Bauermann wrote: >>> Adapt all callers to the new function prototype. >> >> Could you please expand on this? > > Is the following better? > > Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer. Yes and the reason for doing so? Consolidation/clarity of implementation? > >> Looks good otherwise >> >> Acked-by: Balbir Singh > > Thank you for reviewing this series! >