From: John Garry <john.garry@huawei.com>
To: kernel test robot <lkp@intel.com>
Cc: <kbuild-all@lists.01.org>, <linux-kernel@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task_deliver() warn: inconsistent indenting
Date: Wed, 30 Mar 2022 12:49:00 +0100 [thread overview]
Message-ID: <fab277a2-3460-17d2-15ab-e12dea2d5b74@huawei.com> (raw)
In-Reply-To: <202203301533.b4Hty4C7-lkp@intel.com>
On 30/03/2022 08:23, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 1c24a186398f59c80adb9a967486b65c1423a59d
> commit: 095478a6e5bf590f2bbf341569eb25173c9c5f32 scsi: hisi_sas: Use libsas internal abort support
> date: 2 weeks ago
> config: powerpc64-randconfig-m031-20220330 (https://download.01.org/0day-ci/archive/20220330/202203301533.b4Hty4C7-lkp@intel.com/config)
> compiler: powerpc64-linux-gcc (GCC) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> smatch warnings:
> drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task_deliver() warn: inconsistent indenting
>
> vim +445 drivers/scsi/hisi_sas/hisi_sas_main.c
>
...
> 42e7a69368a585 John Garry 2015-11-18 437 case SAS_PROTOCOL_SATA:
> 42e7a69368a585 John Garry 2015-11-18 438 case SAS_PROTOCOL_STP:
> 095478a6e5bf59 John Garry 2022-03-11 439 case SAS_PROTOCOL_STP_ALL:
> a2b3820bddfbff Xiang Chen 2018-05-09 440 hisi_sas_task_prep_ata(hisi_hba, slot);
> 6f2ff1a1311e61 John Garry 2016-01-26 441 break;
> 095478a6e5bf59 John Garry 2022-03-11 442 case SAS_PROTOCOL_INTERNAL_ABORT:
> 095478a6e5bf59 John Garry 2022-03-11 443 hisi_sas_task_prep_abort(hisi_hba, slot);
> dc313f6b125b09 John Garry 2021-12-15 444 break;
> dc313f6b125b09 John Garry 2021-12-15 @445 fallthrough;
This is already queued for removal.
> 42e7a69368a585 John Garry 2015-11-18 446 default:
> 095478a6e5bf59 John Garry 2022-03-11 447 return;
> 42e7a69368a585 John Garry 2015-11-18 448 }
> 42e7a69368a585 John Garry 2015-11-18 449
> 1c09b663168bb5 Xiaofei Tan 2018-07-18 450 WRITE_ONCE(slot->ready, 1);
> 42e7a69368a585 John Garry 2015-11-18 451
> 0e4620856b8933 John Garry 2021-12-15 452 spin_lock(&dq->lock);
> 0e4620856b8933 John Garry 2021-12-15 453 hisi_hba->hw->start_delivery(dq);
> 0e4620856b8933 John Garry 2021-12-15 454 spin_unlock(&dq->lock);
> 42e7a69368a585 John Garry 2015-11-18 455 }
> 42e7a69368a585 John Garry 2015-11-18 456
>
> :::::: The code at line 445 was first introduced by commit
> :::::: dc313f6b125b095d3d2683d94d5f69c8dc9bdc36 scsi: hisi_sas: Factor out task prep and delivery code
>
> :::::: TO: John Garry <john.garry@huawei.com>
> :::::: CC: Martin K. Petersen <martin.petersen@oracle.com>
>
next prev parent reply other threads:[~2022-03-30 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 7:23 kernel test robot
2022-03-30 11:49 ` John Garry [this message]
2022-03-30 17:14 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fab277a2-3460-17d2-15ab-e12dea2d5b74@huawei.com \
--to=john.garry@huawei.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome