mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: quic_vboma@quicinc.com,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Vikash Garodia <vgarodia@qti.qualcomm.com>
Subject: Re: [PATCH 1/1] venus : Fix for H265 decoding failure.
Date: Fri, 2 Dec 2022 00:51:04 +0000	[thread overview]
Message-ID: <fab6a134-21a3-ce49-dede-97f0a4b0dc50@linaro.org> (raw)
In-Reply-To: <20221115121004.28197-2-quic_vboma@quicinc.com>

On 15/11/2022 12:10, quic_vboma@quicinc.com wrote:
> From: Viswanath Boma <quic_vboma@quicinc.com>
> 
> Aligned the mismatch of persist1 and scratch1 buffer calculation,
> as per the firmware requirements .
> 
> Signed-off-by: Vikash Garodia <vgarodia@qti.qualcomm.com>
> Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>
> ---
>   drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c b/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c
> index ea25c451222b..a9be31ec6927 100644
> --- a/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c
> +++ b/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c
> @@ -93,7 +93,7 @@
>   #define LCU_MIN_SIZE_PELS		16
>   #define SIZE_SEI_USERDATA		4096
>   
> -#define H265D_MAX_SLICE			600
> +#define H265D_MAX_SLICE			3600
>   #define SIZE_H265D_HW_PIC_T		SIZE_H264D_HW_PIC_T
>   #define SIZE_H265D_BSE_CMD_PER_BUF	(16 * sizeof(u32))
>   #define SIZE_H265D_VPP_CMD_PER_BUF	256
> @@ -1021,7 +1021,7 @@ static u32 h264d_persist1_size(void)
>   static u32 h265d_persist1_size(void)
>   {
>   	return ALIGN((SIZE_SLIST_BUF_H265 * NUM_SLIST_BUF_H265 + H265_NUM_TILE
> -			* sizeof(u32)), HFI_DMA_ALIGNMENT);
> +			* sizeof(u32) + NUM_HW_PIC_BUF * SIZE_SEI_USERDATA), HFI_DMA_ALIGNMENT);
>   }
>   
>   static u32 vp8d_persist1_size(void)

If this is a real fix it need to be applied elsewhere

Please add a Fixes tag

Fixes: 3a75bf4e7925 ("media: venus: Add platform buffers for v6")

and

Cc: <stable@vger.kernel.org> # 5.14.x

---
bod

  parent reply	other threads:[~2022-12-02  0:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 12:10 [PATCH 0/1] " quic_vboma
2022-11-15 12:10 ` [PATCH 1/1] venus : " quic_vboma
2022-12-02  0:12   ` Nathan Hebert
2022-12-02 19:48     ` Nathan Hebert
2022-12-05  4:48       ` Viswanath Boma (Temp)
2022-12-02  0:51   ` Bryan O'Donoghue [this message]
2023-03-16  7:57   ` [[v1]PATCH 0/1] " quic_vboma
2023-03-16  7:57     ` [PATCH] venus : " quic_vboma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fab6a134-21a3-ce49-dede-97f0a4b0dc50@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vboma@quicinc.com \
    --cc=stanimir.varbanov@linaro.org \
    --cc=vgarodia@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®