Hi Krzysztof, On 10/09/23 4:25 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 08/09/2023 16:29, Parthiban Veerasooran wrote: >> This patch series contain the below updates, >> - Adds support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface in the >> net/ethernet/oa_tc6.c. >> - Adds driver support for Microchip LAN8650/1 Rev.B0 10BASE-T1S MACPHY >> Ethernet driver in the net/ethernet/microchip/lan865x.c. > > And why is this RFC? Do you mean by that it is buggy and not finished, > so we should not review? No, this is not a buggy/unfinished patch series. I have added RFC as this is a new framework is being added in the kernel for supporting OPEN Alliance 10BASE-T1x MACPHY Serial Interface. So I want to get opinion/direction/comments from community members. Your valuable review comments are important to make this framework get added in the mainline. To get more clarity on this activity, I have described my test setup and results here. My test setup has two 10BASE-T1S nodes (node 0 and node 1). Node 0 is with LAN8650 MACPHY and node 1 is with EVB-LAN8670-USB. --------------------------- ---------------------------- | LAN8650 MACPHY (node 0) |<----->| EVB-LAN8670-USB (node 1) | --------------------------- ---------------------------- LAN8650 MACPHY has a MAC and 10BASE-T1S PHY embedded within a single chip. SPI interface for Host. EVB-LAN8670-USB has a LAN9500A USB MAC and LAN8670 10BASE-T1S PHY. USB interface for Host. Product links to refer: LAN8650: https://www.microchip.com/en-us/product/lan8650 EVB-LAN8670-USB: https://www.microchip.com/en-us/development-tool/EV08L38A Node 0: Acts as PLCA coordinator node. Node 1: Acts as PLCA drop node. Note: These products can support CSMA/CD as well. We have already mainlined EVB-LAN8670-USB drivers. Please refer the below links. Driver for LAN9500A USB MAC in the EVB-LAN8670-USB: https://elixir.bootlin.com/linux/latest/source/drivers/net/usb/smsc95xx.c#L2106 Driver for LAN8670 10BASE-T1S PHY in the EVB-LAN8670-USB: https://elixir.bootlin.com/linux/latest/source/drivers/net/phy/microchip_t1s.c#L273 Driver for LAN8650 10BASE-T1S MACPHY's Internal PHY: https://elixir.bootlin.com/linux/latest/source/drivers/net/phy/microchip_t1s.c#L283 Herewith I have attached the ping and iperf3 test results with this driver for your reference. There are two terminals representing node 0 and node 1. Left terminal is LAN8650 MACPHY and the right one is EVB-LAN-8670-USB. ping_test.png: ping test result between two nodes. iperf3_tx_test.png: iperf3 tx test where node 0 sends data to node 1. iperf3_rx_test.png: iperf3 rx test where node 1 sends data to node 0. iperf3_bidirection_test.png: iperf3 bidirectional test where both nodes are sending and receiving. Hope this helps to get a clarity on this activity. Best Regards, Parthiban V > > Best regards, > Krzysztof > >