From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38E1237A493 for ; Wed, 8 Apr 2026 10:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775643857; cv=none; b=f2YYrWgEk1LOxr0o/GScIM3fJur9+QZ6+eUsBGbMkf75faj2QRFavkHO/nvfouYmmo/xpcvq9jyV8R+VB3kLMFObJpED0vQHhTV4FTx86dqlcsMqj3nUfx0WRtPHxbgNOXvAFc2Psx81ywmDnD4cqCLMJdxJNoU19sHSZs2unSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775643857; c=relaxed/simple; bh=W6N8KADh2SvYZjm7PtZfb52lCZindsszU9QX/hsYNpE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CfCUNs+HnwyVHj8fEbFwakSb85Ybn7iKhRwAaknkw+mb9XOqN/p9dDpWF++A7xPrnf/Hea3Oyj0OINwUcev/XKvDv5X/qRdxSU2jYj/bFAJbS5aGcSsabJaYHWDqEyXBAQI+4JAbRF4qYAUbgLOieibgR246bX/+qnMKldzzNFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wAQ4n-0005Ef-RL; Wed, 08 Apr 2026 12:24:01 +0200 Message-ID: Date: Wed, 8 Apr 2026 12:23:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmem: imx-ocotp: Initialize in subsys_initcall To: Paul Geurts , srini@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, p.zabel@pengutronix.de, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: martijn.de.gouw@prodrive-technologies.com References: <20260408101901.2111140-1-paul.geurts@prodrive-technologies.com> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: <20260408101901.2111140-1-paul.geurts@prodrive-technologies.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hello Paul, On 4/8/26 12:19 PM, Paul Geurts wrote: > The i.MX OCOTP driver is implemented as module_platform_driver();, > which makes it initialize in device_initcall(). This means that all > drivers referencing the clock driver nodes in the device tree are > deferred by fw_devlink. > > As the OCOTP driver is arch specific, but dependent on the i.MX clock > driver, which is also initialized in arch_initcall(), explicitly > initialize the driver in subsys_initcall(). This makes sure the drivers > depending on fuses defined by OCOTP, which are initialized in > device_initcall() are not deferred. > > Fixes: 3edba6b47e42 ("nvmem: imx-ocotp: Add i.MX6 OCOTP driver") Same question as the imx8mm-clk patch. Your commit message doesn't mention what problem you had the with deferral. > -module_platform_driver(imx_ocotp_driver); > + > +static int __init imx_ocotp_init(void) > +{ > + return platform_driver_register(&imx_ocotp_driver); > +} > +subsys_initcall(imx_ocotp_init); Same question as before. What happens when you build this as module. Cheers, Ahmad > + > +static void __exit imx_ocotp_exit(void) > +{ > + platform_driver_unregister(&imx_ocotp_driver); > +} > +module_exit(imx_ocotp_exit); > > MODULE_AUTHOR("Philipp Zabel "); > MODULE_DESCRIPTION("i.MX6/i.MX7 OCOTP fuse box driver"); -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |