From: Markus Elfring <Markus.Elfring@web.de>
To: Cheng Jian <cj.chengjian@huawei.com>, kernel-janitors@vger.kernel.org
Cc: Wang ShaoBo <bobo.shaobowang@huawei.com>,
Chen Wandun <chenwandun@huawei.com>,
Li Bin <huawei.libin@huawei.com>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Xie XiuQi <xiexiuqi@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] panic: Fix deadlock in panic()
Date: Wed, 3 Jun 2020 17:30:14 +0200 [thread overview]
Message-ID: <fabff510-bd19-1712-2aa2-b1d742349c39@web.de> (raw)
> A deadlock caused by logbuf_lock occurs when panic:
I suggest a few wording adjustments for this change description.
Would you like to omit an extra space character at the beginning of this sentence?
> we try to re-init …
We …
> … deadlock, but it … here, because :
… deadlock. But it … here because:
> Firstly, …
1. …
> When the CPU bring down …, … CPU willn't
… CPU was brought down …, … CPU will not
> Secondly, …
2. …
> … callback, so if printk() …
… callback. If printk() …
> …, deadlock will still occurs. Eg, …
…, deadlock will still occur. E. g. …
Regards,
Markus
reply other threads:[~2020-06-03 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabff510-bd19-1712-2aa2-b1d742349c39@web.de \
--to=markus.elfring@web.de \
--cc=bobo.shaobowang@huawei.com \
--cc=chenwandun@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®