From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F9140F755 for ; Wed, 22 Jul 2026 13:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784727221; cv=none; b=rpdy3aGBderKtFzFxxHZLi4uP+f0adEV45NsRwFM1WuZgyM57EEeReWFiPvtkHXq+5hgpYyJBR2fwZT/DoRGFVYKqmi/BlXUsUxMHRojGoM5Uf+KdVG7lEendgC5EmJnem40qKOvJdFFUmlUe8vOk6QZguAcsWgN47leSvrLV7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784727221; c=relaxed/simple; bh=IK0nPNyVliHInYc5llgRFImUtg/oBw1zId3SZsnZemc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nu3W2LX+1Atkd5r+SQHiOVeHUcYfCd0r+b4BYnHEYjWuiBcV6bdEJ52rWsxkZcZB2iXtRskU2W11nPYm2vQo42nEeKQwbZQQlPoMmiwqdq5/lJAfCle77Wn0R8gL2jYamJVWeVrNEgDQ48X4YJOi2qQE4ElARec4yY4yb7Wb/G8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p6jGh0aC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PWsgZGVj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p6jGh0aC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PWsgZGVj" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66MDWM6Y646335 for ; Wed, 22 Jul 2026 13:33:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ss0O6hRBUHxNH6IxnPNV86R5Z0G3U/HPz/CmgoZNFtI=; b=p6jGh0aCk4giX1im UEUXR3cYR9ostzr0WwPUNMeTC2ZStLqADyNqeLXAuWslFmvcLOCRSbI9C9LAtlbn 2yD9aSRJfArOChaUI0IOO7kuNkzsxci+L1TT+skYRM6oL1FSGpu7wbGV7U0ynamm LtR5jO8ABsmqGhPQJ/4S41otNC6IQHC1eUULxg/YCMtQP9j6Q/AnfxYLPO8Q2h9/ In/CeWZyFGFW985RtvW3qda/Z6N7MHZSP8XnL3n/dYc23XSc7ElaTzSPgfsdMSA4 MaR4E2/xjjno6CV85K5uXYCx/Szg5/ql4EjAD5XTDM0NyPYKfFFmUDAxbSu93wg9 Dn7PbQ== Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fju2291fq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 13:33:39 +0000 (GMT) Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-451ff8b9acbso5686163fac.0 for ; Wed, 22 Jul 2026 06:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784727219; x=1785332019; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ss0O6hRBUHxNH6IxnPNV86R5Z0G3U/HPz/CmgoZNFtI=; b=PWsgZGVjXDBIoAGsu2FZdGs866C/Y1ixLygtb7ggADaafImueHUzIX5QAJ1cVE44uS dFm7KibElWcX2iJ8mJxWkX3dQ+Ags8MP5nKKov6m+kPzW6UpBJFbBnnQsdlW+e62IOnl NibaUXfPGXdN+KYKprcX+1uTWjlVkNHWT+Dv1SDwszVOaUuxxHHvTlisiNfN/JLDLa5E j4Vp/jB6nnx12jcpYXld9PtstHdNDlg1+CGZtgshQ2ysbzMutOpRBd/wJPm9R796KLAN 8VdKnXsS1zAXuSJUAAjOemHD4KxyrepjgOF57fLVG3gdZIciHW+XFkEkBBb4m6GgyDs6 nzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784727219; x=1785332019; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ss0O6hRBUHxNH6IxnPNV86R5Z0G3U/HPz/CmgoZNFtI=; b=pbpa002wK4zB78PRQJeMX6mjFGs1geu68iB0HeLDprZXh/eanssZhLSd9LUl4tVCWh uZ0jmqGL7vJjvzNz12616t+JJuJm4YaAPQwrWTyThxWJQnUYFRH2Ls0E7TAL5LPAyzAT jMLXUF8WCQujPGBI6+n/rfsUJKfbUkKA3slRwH2CZJ0bLREVRhYy4ciS8SBM+BVIMfoC pkvLV9NwAZg2Uivoseiwt5pVrI5cEUbbzyau8mhjVFoyB6knBpw+92+9liA1FTm0GiDh Jm1XkJf40TeuWYkbmGAbK8ke5yaBqH0ZfPRJ8zynr8Axm6kBVfcHx1iLEUw4gpZj4d3n 77Dw== X-Forwarded-Encrypted: i=1; AHgh+Roz2tV2sydmTc2eyhRyOCEMjj6xurcYg/5n6RjDdAy8KR0b89v2Sq71a9HoI2n7mxv0DUkHt9Vvg4/cx1A=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz8Y7IXcjvEUUzWBgt0Aq52koxc7Hwqt2fsrRK7Ql4bHurtY82 NQFJSNNkQSEXeF7BUuoIizWi+t9/lBzFhZ0gA4PIr8R9cLNM/ALVRI8Yy9ZT2QSg9y0brL2WC/d CJ464M2qIN8Ch6YJ/UUachrdet7YrHDJe4U9V2ut+pa6wtda/gssswLoZPUV5a7MZfcQ= X-Gm-Gg: AR+sD137Pv+e2QPQ4BjNXuiaWmf5RWH3i5gQV3s17wbXUiS++6fxoAFT3m8XvsGfXLg pcEye2AhIBGLNSQoUjbaU0w6e4WI0ON2rCpX1cZj9YZg7FBR98LcBGVHYoRLRsVyfvgXi15/Gx1 qn/sTAMi805aNEnca3X3TJJ5EuSVmPiwSxizZTOiyQGyJFroHt/qUdunM21WCtuUDERZb3t68ix GzF6o2oOVDrCN5oT2bmmRz1xss+11qIJznYhunoKQtoZqKjTRehfX54icDvt5KoEpmJ3ajNnNdK PIVEw7FmCJLU8RHzKh4wVrphNxcbUbR+mHzeJhmzZFmDfijM9rUEEl8anrWjYlC8abvvEQl5boE 7BP343seNreIFzRq2b08rNIOv641AgWzFLrs= X-Received: by 2002:a05:6820:16a0:b0:6a3:e0fe:c4ef with SMTP id 006d021491bc7-6aa4bbd56c9mr1653236eaf.35.1784727218681; Wed, 22 Jul 2026 06:33:38 -0700 (PDT) X-Received: by 2002:a05:6820:16a0:b0:6a3:e0fe:c4ef with SMTP id 006d021491bc7-6aa4bbd56c9mr1653117eaf.35.1784727215447; Wed, 22 Jul 2026 06:33:35 -0700 (PDT) Received: from [10.219.57.229] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6aa79a09cbesm1395149eaf.12.2026.07.22.06.33.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 06:33:35 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 19:03:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 02/13] power: reset: reboot-mode: Support up to 3 magic values per mode To: Pavan Kondeti Cc: Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , mfd@lists.linux.dev, Srinivas Kandagatla References: <20260714-arm-psci-system_reset2-vendor-reboots-v23-0-e7453c548c21@oss.qualcomm.com> <20260714-arm-psci-system_reset2-vendor-reboots-v23-2-e7453c548c21@oss.qualcomm.com> <38115586-9913-4d6e-9447-e82aee811dd1@quicinc.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: <38115586-9913-4d6e-9447-e82aee811dd1@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=X4Bi7mTe c=1 sm=1 tr=0 ts=6a60c6b3 cx=c_pps a=nSjmGuzVYOmhOUYzIAhsAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Fs1vR9WLwBkDfa--pcoA:9 a=QEXdDO2ut3YA:10 a=1zu1i0D7hVQfj8NKfPKu:22 X-Proofpoint-GUID: 2iGKFA18Q8gjFMUjNoIGuWfXPJoC7peS X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEzMiBTYWx0ZWRfX9MdfDRl7WRTH zyVqX9Au1lTJG7t+798h8Ta7mE+9HMVrO4YEGTEbSjESaLCqdoegA1ZFmELDVNXZXNIW2ye8+pm ouAFEqbYzy8jIffzqxRXdBPZSExITbA= X-Proofpoint-ORIG-GUID: 2iGKFA18Q8gjFMUjNoIGuWfXPJoC7peS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEzMiBTYWx0ZWRfX0iATHL5DqKzb 6M7IgDJIl0BIeOcAzUKA3u9TgED1nshPtbmwIWHQrSIv6CEmVfHinRyBtDoGwPxGZuv5JxnUcHP iyHAOpHbBAOxF71CbFKMuKUi2n8hom/r01vvXYgCvTNxO288BRXf4NprMBaL/9559h1I4i31Gmc FYrr1/i31UlpOwvI4RoaJ/H+Q0aFoWWJQvOdAXYIv/KyzmeTLEgvlZvMIRilUhCBQItcoB3VVsB rmfITGuyJ7nH83gMHB/MTtc9lzyCp9/mQoih44PEgOLn2RXFCv5ZffTctQ5Pzzx4pWfQXa4ueR8 tZ00g4lmXvi4jE97ZgL8oyjrYT8WQPIlm8H497ork8dNP5Smo6dJvFZ+ctR/jVOEUahblF6IEic KT3WfONUR08VBa5MOABzRDsHgIGGrZV1fGFl9pdKb2JCzhVnT7PA7/IfzqBX/GGrIJrabbA4tgs UlAFHwCS8BKW0/p+Ykw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_04,2026-07-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220132 On 22-07-2026 15:20, Pavan Kondeti wrote: > On Tue, Jul 14, 2026 at 10:46:30PM +0530, Shivendra Pratap wrote: >> ARM PSCI vendor-specific resets, require a 32-bit reset_type and a 64-bit >> cookie as arguments. This cannot be implemented via the reboot-mode >> framework, which supports a single 32-bit argument as magic value. >> >> Extend the reboot-mode framework to support up to three 32-bit arguments >> as magic, per reboot-mode. >> >> Signed-off-by: Shivendra Pratap >> --- >> drivers/power/reset/nvmem-reboot-mode.c | 10 ++++---- >> drivers/power/reset/qcom-pon.c | 8 ++++--- >> drivers/power/reset/reboot-mode.c | 41 +++++++++++++++++++++----------- >> drivers/power/reset/syscon-reboot-mode.c | 8 ++++--- >> include/linux/reboot-mode.h | 4 +++- >> 5 files changed, 46 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/nvmem-reboot-mode.c >> index d260715fccf6..ac69b5f39fb4 100644 >> --- a/drivers/power/reset/nvmem-reboot-mode.c >> +++ b/drivers/power/reset/nvmem-reboot-mode.c >> @@ -17,14 +17,16 @@ struct nvmem_reboot_mode { >> struct nvmem_cell *cell; >> }; >> >> -static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot, >> - unsigned int magic) >> +static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot, u32 *magic, int count) >> { >> struct nvmem_reboot_mode *nvmem_rbm; >> size_t buf_len; >> void *buf; >> int ret; >> >> + if (count != 1) >> + return -EINVAL; >> + > > The count can be different per mode. Because `struct mode_info` has > `count` member. This single `count` check across all modes may not be > useful. > > Either drivers need to use count passed to them or drivers needs to > receive `struct mode_info` in the callabck. will add a once more write function in reboot-mode to handle the multi-count support. If a driver implements it, the multi-count write function will be called. And no change in existing drivers. Does that address this concern? thanks, Shivendra