From: Murali Karicheri <m-karicheri2@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-api@vger.kernel.org>,
<nsekhar@ti.com>, <grygorii.strashko@ti.com>,
<vinicius.gomes@intel.com>
Subject: Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP
Date: Mon, 20 Jul 2020 09:19:32 -0400 [thread overview]
Message-ID: <fac7f266-98e5-2750-7230-d4e6bc94b4d4@ti.com> (raw)
In-Reply-To: <20200717.185611.1278374862685166021.davem@davemloft.net>
On 7/17/20 9:56 PM, David Miller wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
> Date: Fri, 17 Jul 2020 11:15:05 -0400
>
>> @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev,
>> struct netlink_ext_ack *extack)
>> {
>> struct net_device *link[2];
>> - unsigned char multicast_spec, hsr_version;
>> + unsigned char multicast_spec;
>> + enum hsr_version proto_version;
>> + u8 proto = HSR_PROTOCOL_HSR;
>
> Please use reverse christmas tree ordering for local variables.
>
Ok.
> Thank you.
>
--
Murali Karicheri
Texas Instruments
next prev parent reply other threads:[~2020-07-20 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 15:15 [net-next PATCH v3 0/7] Add PRP driver Murali Karicheri
2020-07-17 15:15 ` [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP Murali Karicheri
2020-07-18 1:56 ` David Miller
2020-07-20 13:19 ` Murali Karicheri [this message]
2020-07-17 15:15 ` [net-next PATCH v3 2/7] net: hsr: introduce common code for skb initialization Murali Karicheri
2020-07-18 1:56 ` David Miller
2020-07-20 13:20 ` Murali Karicheri
2020-07-17 15:15 ` [net-next PATCH v3 3/7] net: hsr: introduce protocol specific function pointers Murali Karicheri
2020-07-17 15:15 ` [net-next PATCH v3 4/7] net: prp: add supervision frame generation utility function Murali Karicheri
2020-07-17 15:15 ` [net-next PATCH v3 5/7] net: hsr: define and use proto_ops ptrs to handle hsr specific frames Murali Karicheri
2020-07-17 15:15 ` [net-next PATCH v3 6/7] net: prp: add packet handling support Murali Karicheri
2020-07-17 15:15 ` [net-next PATCH v3 7/7] net: prp: enhance debugfs to display PRP info Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac7f266-98e5-2750-7230-d4e6bc94b4d4@ti.com \
--to=m-karicheri2@ti.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®