From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD26F3A1A5B for ; Tue, 14 Apr 2026 08:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155227; cv=none; b=b6lkxbQnrZMaPfD2LQWse9mwDAFxrF9UsPW+NQjt4mr5j/40EV/ybGYb+JC6HEhxedaJK08LCp6vT65/XnIsoM0uaJ8o5c1qPAUcvuiteLbG2dkG99c5BWqQdPMGkDhQBJTi5aOIoizLv6B12pNUiFbLVb38boa9n7mUmxLUzZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155227; c=relaxed/simple; bh=F4paP3AYrGUdXYxOVyHozv15q2PNZRMdSNaf9srxWgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JFjmuMMjcJi8WHG2yqsY8Pg3cpnnpJhqrq7opA6o+oA1rx9bLAngEXDIVMxyz43VjOHRj/dSNQ8GGosdy7Cxy2elDgnIDEGq1EfxdWSzNXU+5PPV70X7vAZvaNLQJgNotkS85n3I4MVv/iJCDghrwaLditfEIr007WAmwH31fmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kiH8ofOI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UU8HEa1U; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kiH8ofOI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UU8HEa1U" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6dvTZ2633494 for ; Tue, 14 Apr 2026 08:27:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uDT//1wLOvhRQGRYA5N8g1SyqlnI49rmAoCo4iiPEqw=; b=kiH8ofOIHJPqgGzs k8wLk/jOHYJ/xn6j9pHkqxc16RAhfp0kgrXWhGSt1wDKjQz+THZy/sxSiFyAiDRN 34NLXbb3wEAJa1TlC7fc85kwViSpVTv5JdvQQLomcvHQ9yMTEnfOU/aEbqaMR0IM u6kuFzqajzFCIOjCEWNp/98x1xL0m8nlpK+9AFjLoJEZIyfvaf7ykhgesQL2GZ0z GzZvtoAYPsdEO8QMsqdVkhRbA/8qu/+pqIMKVcDZCSoaqwrS+81+SnEuYqG+jVGX X7mHo2gWkWyKvosVu6Pv/1wGBCC9M8IqCWFu6Pf7GjEf+E1BDRFhGikIQOiwYPW+ tlyAfw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh86c9spt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:27:05 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8d0095b0d80so154892685a.1 for ; Tue, 14 Apr 2026 01:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776155224; x=1776760024; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uDT//1wLOvhRQGRYA5N8g1SyqlnI49rmAoCo4iiPEqw=; b=UU8HEa1USsEA+BcM5WyK2HtFNCuogwN7cGe5ibPgRtZEufHm2JVzTkgSW/tRt3/iyF aVmkJBEr8WUfzPScKRc2KvUzkkBwQB3lEFomqHX3j4+f4/YI4tPpp2/VfZbLjvAid/WQ 2LrC7yt9y2BYHaePVCoae8tGlju2t0rwHciN0cxxSnc1z4anQN7+ZcSXhJvXe4LhIscy E7lvTIdLdT68ENN2D7g9uocMYmokcWDicOa119VgRfsXq8mLriBlWUlbMt7X3csY7rlL RAiSfG217nVrs/94ITs4gX+GIrDCFkOEjSOU8zzwbbWDhCiQVryxQHdzPENwOqKpOnZI qruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776155224; x=1776760024; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uDT//1wLOvhRQGRYA5N8g1SyqlnI49rmAoCo4iiPEqw=; b=bnaNsDeCNhmWMcvZpElfV+fBJBS+LtBm58euara2vGE4MS33/w5EYqRic6dFJr/nbH yP5rcrTfEGcQ/ZgwTe8wHPDaYTYQ81f2ghcYN7V3xDsvtvcjVIKj03SFVXEvtbe3DF1H RhWZFYrSskXd5odmnZkQCACYwUxlpvU3kkyOp61ndQgzTVbTbsDhPS6IUre/XrWVl+NJ Jow/y15kQwwhI7a3ZGyYiNOWDJHId7fcfrU6jdCQ4HPBiDDz/xh0Iu1Nk8MdOq56iMD1 /uxdsn5goYKeg1KFu7RoMI5halSG7XWKEfviZC395d3vWGnrHFL8ghFKg4akkIO5gmEk seYw== X-Forwarded-Encrypted: i=1; AFNElJ89pz7G6/8S9OEUAo/6XQfSh2dgqGVHOi7WZjutLYR6zQTS3YLG5gqMPba1tE8nMJsWakucMAtax+k9UX0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3gyL06/fUThVwNOBIuwCv6g4nN//NXiUIyzPbx4fmHU8MFWmk /5x5ofbcKU3wNw6VVfkmSNgN5pc6ZkbhL7o94860nZNd5s3wP/bxnxc1BiVGzPWwcnkE2Xo9eA6 qhyt6CUE6zXLHJHOcCiFY9JrpWj7Pnx6Lc1CGzh8dYc2yLUE1zHwl/ECuVB3K4PIlXgGEAOLl+P k= X-Gm-Gg: AeBDietMXU+4YREb2iuPcaC38K1K0Zla39CaADYASCb/UEogftlKAqK/TPpjaDAqMLZ rHrI+899eE4D23hSUWK5xFDlU5Ez+iliLEdbGwKzsy/bJtA3zkeVEvfhvHoEyXJTqGFeC6buUAT 3hT0UhgUX3qrucVqM5q9yU+1d0770nfAwsqD7VgeACTGYs0SwFlsDImadYB0wwZk0c+R8VgFjzN aeca46+liVOwT6m5aqXMysXxqthuoKKnmfgDk8buX0v1uHIEo2dguPHuDRyMUc0ILsLfaGc84ap rhubxvNG88+pZjP+i5wwBNW4pVFPpdftSyS7rQay04ClJhwfSvVTmqJQhuZRlnhS95ZmJ9TDAvR Prw0kPVIdC6VV79ZngXz+Hlh9nD4EVqDVB/mk9nXpsfUi0+f2LoLPL1YhD6OpcU5izSRqBN4wFj zafD2phxorCLjPtw== X-Received: by 2002:a05:620a:1a0c:b0:8cf:dbad:263 with SMTP id af79cd13be357-8ddd00a8658mr1644298585a.7.1776155223948; Tue, 14 Apr 2026 01:27:03 -0700 (PDT) X-Received: by 2002:a05:620a:1a0c:b0:8cf:dbad:263 with SMTP id af79cd13be357-8ddd00a8658mr1644295985a.7.1776155223432; Tue, 14 Apr 2026 01:27:03 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67070815d27sm2847759a12.24.2026.04.14.01.27.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:27:02 -0700 (PDT) Message-ID: Date: Tue, 14 Apr 2026 10:27:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] clk: qcom: clk-rpmh: Make all VRMs optional by default To: Alexander Koskovich , Abel Vesa Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260412-clk-rpmh-vrm-opt-v1-0-37c890c420ff@pm.me> <20260412-clk-rpmh-vrm-opt-v1-2-37c890c420ff@pm.me> <4dafae66-1ef1-404c-854c-b72d3313f5af@oss.qualcomm.com> <70GGl_MdOrdjIh3ZXqqz5y2NU0HwZ-HIZIzhglTAIpsyiFeyFKqDUUQe8f-krzLSzirMGLjlDsk2YK3-Qo5c7XGqv8qq6NK5F_UCPdt_hqE=@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <70GGl_MdOrdjIh3ZXqqz5y2NU0HwZ-HIZIzhglTAIpsyiFeyFKqDUUQe8f-krzLSzirMGLjlDsk2YK3-Qo5c7XGqv8qq6NK5F_UCPdt_hqE=@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: r7YF-TS4gotCeFJ6ssOTXyMHVloYmiNG X-Authority-Analysis: v=2.4 cv=RoH16imK c=1 sm=1 tr=0 ts=69ddfa59 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=HsagrseOr4lGoIFxeuAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA3OCBTYWx0ZWRfXzjXSld/Snvg9 W5uySQzuf4egyntMNtmqmIiGA+A7Bd/Mcz1o/uQTLB8liys3gSM5anrlNKSVnu4rsE5Evo5vSmM bO91SLjmsylltsMd/ury9XteYPki8xMErdfHF7DI+htxCzpdcjkrx9txhidqjzvKO/KoMoZbTbY uFlNpuDz2kkZ2DGs4zioxy6BvO4maJFM7mxAnDfQumK+9VgXVI9z0XCLUH9ilYiacmrs2eNGRzD /ce4S+tSf0f+VJDqpQv3oMXf2d2D1CGdkhfDL4Y/jjAAIG5cg2p23LwhmEoP0MiTegtvNM3QKRd dfYO9Yy2uQzDIq9ac/++iw8Oen0r2fu6kSVOMz9wwYuNbjrNF6cUUj4IBYWBc84G/ccqX9t8Ll5 kz6ZUrgS5EWZeyllXzUY9fg1pDMKxrSUm/HzR/YA/xMB9MStyipe3948Ps5M/OFjRYGYJzFe0mL nUpzrg9OvowaJg21DgA== X-Proofpoint-GUID: r7YF-TS4gotCeFJ6ssOTXyMHVloYmiNG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140078 On 4/13/26 11:02 AM, Alexander Koskovich wrote: > On Monday, April 13th, 2026 at 4:48 AM, Konrad Dybcio wrote: > >> On 4/12/26 5:30 PM, Alexander Koskovich wrote: >>> Some VRMs aren't present on all boards, so mark them as optional. This >>> prevents probe failures on boards where not all VRMs are present. >>> >>> This mirrors the downstream approach for this issue. >>> >>> Signed-off-by: Alexander Koskovich >>> --- >> >> [...] >> >>> @@ -976,6 +982,11 @@ static int clk_rpmh_probe(struct platform_device *pdev) >>> rpmh_clk = to_clk_rpmh(hw_clks[i]); >>> res_addr = cmd_db_read_addr(rpmh_clk->res_name); >>> if (!res_addr) { >>> + hw_clks[i] = NULL; >>> + >>> + if (rpmh_clk->optional) >>> + continue; >> >> if (rpmh_clk->offset == CLK_RPMH_VRM_EN_OFFSET)? >> >> That would let you drop the rest of the patch. >> >> This also needs some additional background.. I would assume this comes from >> a slightly different HW (PMIC) configuration >> >> Could you please do `grep ^ /sys/kernel/debug/qcom_socinfo/*`, (perhaps >> censoring your serial number)? > > /sys/kernel/debug/qcom_socinfo/accessory_chip:0 > /sys/kernel/debug/qcom_socinfo/boot_cluster:0 > /sys/kernel/debug/qcom_socinfo/boot_core:0 > /sys/kernel/debug/qcom_socinfo/build_id: > /sys/kernel/debug/qcom_socinfo/chip_family:0x0000009f > /sys/kernel/debug/qcom_socinfo/chip_id:SM7750 > /sys/kernel/debug/qcom_socinfo/feature_code:2 > /sys/kernel/debug/qcom_socinfo/foundry_id:1 > /sys/kernel/debug/qcom_socinfo/hardware_platform:11 > /sys/kernel/debug/qcom_socinfo/hardware_platform_subtype:0 > /sys/kernel/debug/qcom_socinfo/info_fmt:0x00000016 > /sys/kernel/debug/qcom_socinfo/ncluster_array_offset:228 > /sys/kernel/debug/qcom_socinfo/nmodem_supported:4294967295 > /sys/kernel/debug/qcom_socinfo/nproduct_id:1135 > /sys/kernel/debug/qcom_socinfo/nsubset_parts_array_offset:232 > /sys/kernel/debug/qcom_socinfo/num_clusters:1 > /sys/kernel/debug/qcom_socinfo/num_func_clusters:1 > /sys/kernel/debug/qcom_socinfo/num_subset_parts:20 > /sys/kernel/debug/qcom_socinfo/oem_variant:0 > /sys/kernel/debug/qcom_socinfo/pcode:1 > /sys/kernel/debug/qcom_socinfo/platform_version:65536 > /sys/kernel/debug/qcom_socinfo/pmic_die_rev:2.1 > /sys/kernel/debug/qcom_socinfo/pmic_model:PMK8550 > /sys/kernel/debug/qcom_socinfo/pmic_model_array:PMK8550 2.1 > /sys/kernel/debug/qcom_socinfo/pmic_model_array:PM7550 1.1 > /sys/kernel/debug/qcom_socinfo/pmic_model_array:PM8550VS 2.0 > /sys/kernel/debug/qcom_socinfo/pmic_model_array:PM8550VS 2.0 > /sys/kernel/debug/qcom_socinfo/pmic_model_array:unknown (90) > /sys/kernel/debug/qcom_socinfo/pmic_model_array:PMR735D 2.0 So you have: your phone vs Abel's Eliza-MTP PMK8550 PMK8550 PM7550 PM7550 PM8550VS PM8550VS PM8550VS PM8550VS PMIV0102 (90) PM7550BA [!] PMR735D PMR735D PM8010 [!] PM8010 [!] And hence the difference, makes sense Konrad