mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Gary Bisson <gary.bisson@boundarydevices.com>, <shawnguo@kernel.org>
Cc: <linus.walleij@linaro.org>, <van.freenix@gmail.com>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization
Date: Thu, 24 Nov 2016 22:17:55 +0200	[thread overview]
Message-ID: <fac988ce-f5be-e50c-8436-c122175f03da@mentor.com> (raw)
In-Reply-To: <20161124181151.29419-1-gary.bisson@boundarydevices.com>

Hi Gary,

On 11/24/2016 08:11 PM, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>  	imx_pinctrl_desc->name = dev_name(&pdev->dev);
>  	imx_pinctrl_desc->pins = info->pins;
>  	imx_pinctrl_desc->npins = info->npins;
> -	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> -	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> -	imx_pinctrl_desc->confops = &imx_pinconf_ops,
> -	imx_pinctrl_desc->owner = THIS_MODULE,
> +	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> +	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> +	imx_pinctrl_desc->confops = &imx_pinconf_ops;
> +	imx_pinctrl_desc->owner = THIS_MODULE;
>
>  	ret = imx_pinctrl_probe_dt(pdev, info);
>  	if (ret) {
>

excellent catch, my compiler does not report the issue.

Subject and commit message are not quite informative, but
the change is trivial, so please feel free to add my

Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>

--
With best wishes,
Vladimir

  parent reply	other threads:[~2016-11-24 20:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 18:11 Gary Bisson
2016-11-24 18:14 ` Gary Bisson
2016-11-24 20:17 ` Vladimir Zapolskiy [this message]
2016-11-25  1:16 ` Peng Fan
2016-11-25 13:11 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fac988ce-f5be-e50c-8436-c122175f03da@mentor.com \
    --to=vladimir_zapolskiy@mentor.com \
    --cc=gary.bisson@boundarydevices.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=van.freenix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®