From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52266C433EF for ; Mon, 28 Mar 2022 19:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241539AbiC1TSc (ORCPT ); Mon, 28 Mar 2022 15:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343598AbiC1TSI (ORCPT ); Mon, 28 Mar 2022 15:18:08 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B9D6662F; Mon, 28 Mar 2022 12:16:26 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1nYuqk-000YoB-Mr; Mon, 28 Mar 2022 21:16:22 +0200 Received: from p57bd9b9a.dip0.t-ipconnect.de ([87.189.155.154] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (envelope-from ) id 1nYuqk-003a6u-G9; Mon, 28 Mar 2022 21:16:22 +0200 Message-ID: Date: Mon, 28 Mar 2022 21:16:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] ia64: topology: Fix an error handling path in cache_add_dev() Content-Language: en-US To: Christophe JAILLET , Tony Luck , Zhang Yanmin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-ia64@vger.kernel.org, Andrew Morton References: <452b20c160a20754022407acefd2abb170f43d14.1648494330.git.christophe.jaillet@wanadoo.fr> From: John Paul Adrian Glaubitz In-Reply-To: <452b20c160a20754022407acefd2abb170f43d14.1648494330.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.155.154 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe! On 3/28/22 21:07, Christophe JAILLET wrote: > If kobject_init_and_add()fails, kobject_put() needs to be called. > Add the missing call which is already there a few lines below in another > error handling path. > > Fixes: f19180056ea0 ("[IA64] Export cpu cache info by sysfs") > Signed-off-by: Christophe JAILLET Thanks for your patches. There is currently no maintainer for ia64, so the patches would have to go through Andrew Morton's tree. However, I can test the patches and verify they don't break anything. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913