From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B23417F4F6 for ; Sun, 6 Jul 2025 15:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751816960; cv=none; b=K61LBsZ1pIHkMvOcosJe4CaR3ab5IFfvZx6iy1ofXqH0UKcgnCBS8XqtnN7GS5DZqzu0S8zCxgzmmxEqIqQZKxa8TnErGmLLxwC64KvhvL3WFuEOb9dQnd07EFqZ5OdQxJOlsPzYTu+cLtfME1XL76jy4HGR5FByXrNb07PBYW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751816960; c=relaxed/simple; bh=cieKeTW7sxZrANoBfT0pl2UQfcrvI1ussoOX7pNgN9E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bMos1shxtc/kIECMPZVXQti4GFV3N8KNZBB5OW/joqoW9sFisQsGZoYJWYpIjrGwGC/i5VRk6vmxPkpoH8TPkvOPVf7C362TSKDti4V2dMuB5XvyTzedx4wq3/YfCLTtq2amSY6L5qeVui8z23C9hHLdo7caB+v6YkBM+KxZjjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lz/iyNl/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lz/iyNl/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 566BYGVF000670 for ; Sun, 6 Jul 2025 15:49:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ThkIhhBJ5fwEX1d3VOih6G8zDuT1c+BI7IZw68KecMw=; b=lz/iyNl/N9CHjE0p 3apskZunHVG9s0rLAZRWu2ZJF2uszP8tCShA6f5IPW5x48s0jSl++5qLS+ryGluD 86FPRQp0KaIQxIZO9xbzPZnsDifbzk0zM22nXQB1onxatgHh1f3l/oPzyCrTCVLw OuHGYJXBnk6vGiSlzph31Jm78bZEzTd1w44bb3vC+QPYzSVXvgFhpr2L00ZyvXlo llctYe5p/01s/78rcm5NtHFHwQDiu8lPj9ozI/6yJwiPlbW07fZSDz3nDKVTSOzy 74SoNKMi5RlIFr4DUSZHx0/WpVO8Ti8595b5LQcSFrdR73vVqtTJP4SRpIjUAVHQ WBXbQw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47psdqdan0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 06 Jul 2025 15:49:16 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7d413a10b4cso364385285a.1 for ; Sun, 06 Jul 2025 08:49:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751816956; x=1752421756; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ThkIhhBJ5fwEX1d3VOih6G8zDuT1c+BI7IZw68KecMw=; b=LvgWFx8gOlRBfkm1z5I1H0BKKG9/PLuzhoDevO1fi33ldchm/bIqJB4u6IduS2N1bt jMTj3TyF8AOeH38tx/5txAd/+TQXElkDqJupdCwiulfMp7BBaX+E3/XM6T1gEyLX2mK5 JOC4+YGuiXgR97K4E7pqVK/VI+EbfSiBliux1FGezkc3MJpxmvoEkywvNrBhs4RTqTnj l8FNmkGmeC/kvEmAwLdRNCrRttuqikgKBaOWwYpc+mImIDNPDHu2R8QvLfdegsDRrLX2 ZE71DVp6hqcny1WM5DMw9Qyn5w8Zw/MGke8qOMph1lDtz9MxmkyC0dX9x0pMz2YSYUiL SweQ== X-Forwarded-Encrypted: i=1; AJvYcCWQ1+yl5uz6vqhoTBoBF2bRwURtw1ps4DZH2zoiJ94ohR7pCe4RQO0PNxekulSv28t/GniV84OtsWCxt0k=@vger.kernel.org X-Gm-Message-State: AOJu0YxFnfKUf7v7UZ8742u3DM1ozW2IM2TutFa7UqPzIpc+A0GL3YAq uD+3u5p/gmCf0n/l9HnxTys3X9gYWbSJd1tiFZjz5TwxS4GJQgWn9V7JLQL+1ASg2dvZJ7ccW47 CIGBaB4S6FG/9AhpmeiZBqPJjZIKgY4UXQjBSRKslYWQMxio0z68lyev5Jp0xLTW24AI= X-Gm-Gg: ASbGncu+UFUFVg0jfbHmA5ywjocz1amMzaa9oGysr7p/TsWHCU6hZFRmuKEFTQpo2IJ Sm3wNxp54IDT3GeFtfvwFyt3SNKaacX7y7JLs3eU0VI93Xm+b70wWhOr/ErWJpqrMClt44uqas0 oBpuAr5D5XSv/pTUuyIkG/VBG9Oa9VRdDJarJbHrFSJHvJn/YoC76cjDpRLbEF4iY+fek5kZU6n V/kGLtf20IiRo7qDlOSSjKHzegbhQzToPJra6G2yJFW5dbN79UZWwS3+j5BlkTYfxVmWNELPHpn 21kFCqAeGwNlaLf4sAf1XrsxOCw9X1v1N3/Raf8jlNdhfh7Krpdh6QfK/MySeO/klMqH04z9+eB dFSlIAT+BFMLj30zmPVmvnTYkLg== X-Received: by 2002:a05:620a:2705:b0:7d3:9012:75b7 with SMTP id af79cd13be357-7d5f28776d5mr604201285a.31.1751816955602; Sun, 06 Jul 2025 08:49:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGmoz2irg953lfmYPzSg/oryohS4RfR4eZsTBB966t6LMzMt5vdU+OciSZSHFurHT6z3Gtzw== X-Received: by 2002:a05:620a:2705:b0:7d3:9012:75b7 with SMTP id af79cd13be357-7d5f28776d5mr604199085a.31.1751816955160; Sun, 06 Jul 2025 08:49:15 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0c3:3a00::4c9? (2001-14ba-a0c3-3a00--4c9.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::4c9]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556384a9123sm974422e87.168.2025.07.06.08.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Jul 2025 08:49:14 -0700 (PDT) Message-ID: Date: Sun, 6 Jul 2025 18:49:13 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] drm/msm/mdp4: use msm_kms_init_vm() instead of duplicating it To: rob.clark@oss.qualcomm.com Cc: Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250706-msm-no-iommu-v1-0-9e8274b30c33@oss.qualcomm.com> <20250706-msm-no-iommu-v1-3-9e8274b30c33@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ffSty1QF c=1 sm=1 tr=0 ts=686a9afc cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=cS33hYv70hVWqaF04D4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: _oBNlX87mcpxEJhKCfrLuif1SHGuiybX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA2MDEwMSBTYWx0ZWRfX4T32lOZcOQ4p siSi77TSFsOwkuoKTsmWcwVqQL4IZC8alojRKqcVzv0veZcuCC0oGd7BUqitGQdNb1KXur3euFq EBGVUxl6gbuUHk7Vicu7tn04652ZN7o9F7VAUHrLHDbKg+M0ABv0jDxKxgISwO9dLx8O65KCjfl gIryQUAhEVnDtdRXI/THJhIAk7J9aisIstFWSjj1+HV8Otuo6NIjJBfHCtiIeM//VQD1tIY4nKn sYcUtPKYafttJLANa4P8+To0LSBBWbCrgx9GPioQNUh/fp7weFfsfRnp+Dlm2jWhHd2ZtwExqlF dR1Rfzh5Y9G4uPKXnrqTie/+xVvOrNbsO2BFFO+E5Z/Kt2TqafdOKgqLmXO18jpuXeBgWux0C24 BsXNellQB8yjvbWf9morgoJVFEq8ttEGiYQjWm6CfwIqWE97mVzChkj8rc5Ogex7kuzswgVY X-Proofpoint-GUID: _oBNlX87mcpxEJhKCfrLuif1SHGuiybX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_07,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507060101 On 06/07/2025 18:11, Rob Clark wrote: > On Sun, Jul 6, 2025 at 7:02 AM Dmitry Baryshkov > wrote: >> >> On Sun, 6 Jul 2025 at 16:11, Rob Clark wrote: >>> >>> On Sun, Jul 6, 2025 at 3:50 AM Dmitry Baryshkov >>> wrote: >>>> >>>> Use the msm_kms_init_vm() function to allocate memory manager instead of >>>> hand-coding a copy of it. Although MDP4 platforms don't have MDSS >>>> device, it's still safe to use the function as all MDP4 devices have >>>> IOMMU and the parent of the MDP4 is the root SoC device. >>> >>> So, originally the distinction was that mdp4 didn't have the mdss >>> wrapper. Maybe it works out because device_iommu_mapped(mdp_dev) >>> returns true? >> >> Yes, as expressed in the cover letter. > > Right, but with this patch, I think nothing is enforcing that, so we > could end up dereferencing mdp_dev->parent if the device did not have > an iommu. > > I guess you could solve that with an extra device_iommu_mapped() in > mdp4_kms_init() ... or adding have_mdss arg to msm_kms_init_vm(). Anyway, let's probably get first two patches in, I'll repost the third patch later on. > > BR, > -R > >>> >>> BR, >>> -R >>> >>>> Signed-off-by: Dmitry Baryshkov >>>> --- >>>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 27 +++++---------------------- >>>> 1 file changed, 5 insertions(+), 22 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c >>>> index 88296c41d1a5eb0e16cb6ec4d0475000b6318c4e..41d236d30e71ebb6ac8a59052529f36fadf15cd7 100644 >>>> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c >>>> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c >>>> @@ -391,11 +391,9 @@ static void read_mdp_hw_revision(struct mdp4_kms *mdp4_kms, >>>> >>>> static int mdp4_kms_init(struct drm_device *dev) >>>> { >>>> - struct platform_device *pdev = to_platform_device(dev->dev); >>>> struct msm_drm_private *priv = dev->dev_private; >>>> struct mdp4_kms *mdp4_kms = to_mdp4_kms(to_mdp_kms(priv->kms)); >>>> struct msm_kms *kms = NULL; >>>> - struct msm_mmu *mmu; >>>> struct drm_gpuvm *vm; >>>> int ret; >>>> u32 major, minor; >>>> @@ -458,29 +456,14 @@ static int mdp4_kms_init(struct drm_device *dev) >>>> mdp4_disable(mdp4_kms); >>>> mdelay(16); >>>> >>>> - mmu = msm_iommu_new(&pdev->dev, 0); >>>> - if (IS_ERR(mmu)) { >>>> - ret = PTR_ERR(mmu); >>>> + vm = msm_kms_init_vm(mdp4_kms->dev); >>>> + if (IS_ERR(vm)) { >>>> + ret = PTR_ERR(vm); >>>> goto fail; >>>> - } else if (!mmu) { >>>> - DRM_DEV_INFO(dev->dev, "no IOMMU configuration is no longer supported\n"); >>>> - ret = -ENODEV; >>>> - goto fail; >>>> - } else { >>>> - vm = msm_gem_vm_create(dev, mmu, "mdp4", >>>> - 0x1000, 0x100000000 - 0x1000, >>>> - true); >>>> - >>>> - if (IS_ERR(vm)) { >>>> - if (!IS_ERR(mmu)) >>>> - mmu->funcs->destroy(mmu); >>>> - ret = PTR_ERR(vm); >>>> - goto fail; >>>> - } >>>> - >>>> - kms->vm = vm; >>>> } >>>> >>>> + kms->vm = vm; >>>> + >>>> ret = modeset_init(mdp4_kms); >>>> if (ret) { >>>> DRM_DEV_ERROR(dev->dev, "modeset_init failed: %d\n", ret); >>>> >>>> -- >>>> 2.39.5 >>>> >> >> >> >> -- >> With best wishes >> Dmitry -- With best wishes Dmitry