From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F083E95A82 for ; Sun, 8 Oct 2023 12:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344769AbjJHM6V (ORCPT ); Sun, 8 Oct 2023 08:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344746AbjJHM6U (ORCPT ); Sun, 8 Oct 2023 08:58:20 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B97F7B6 for ; Sun, 8 Oct 2023 05:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1696769896; bh=/RO3QHXfL+NTLkG4EZZUqGjM+mCMQvp6gTE71nmlGR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dvgIYanICafKJJYhqUdFl2IibTwsKiwLsiwSntOZOmwef15ge+LNeYgsGAhNi+EDJ IhSgz/5Ap16iHReL5Q0mGiq4tJ/zFRmMmVpi5KH7OAmFZkQR5deeP9TYEcSb0ve96Y cbyGe8HtOr1o1kOf/MVK1ToyFrAbi50rVNfUGvj0= Date: Sun, 8 Oct 2023 14:58:15 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: "Paul E. McKenney" Cc: Willy Tarreau , Shuah Khan , Shuah Khan , linux-kernel@vger.kernel.org Subject: Re: nolibc changes since 6.6-rc1 for linux-next Message-ID: References: <11a790c0-f9c0-49eb-b14f-56b962af6d2d@t-8ch.de> <48c01af3-d373-4546-a8f2-d81fa447eaaa@t-8ch.de> <25382680-956a-4612-b930-f6823c71cf8d@paulmck-laptop> <696fc488-63d3-444c-a9f2-14d7a7379143@linuxfoundation.org> <23bc3841-4cda-4a23-a67f-a944e1104f1d@paulmck-laptop> <20231007070630.GB20998@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 2023-10-07 08:42:53-0700, Paul E. McKenney wrote: > On Sat, Oct 07, 2023 at 09:06:30AM +0200, Willy Tarreau wrote: > > On Thu, Oct 05, 2023 at 05:01:22PM -0700, Paul E. McKenney wrote: > > > On Thu, Oct 05, 2023 at 03:30:52PM -0600, Shuah Khan wrote: > > > > On 10/5/23 14:58, Paul E. McKenney wrote: > > > > > On Thu, Oct 05, 2023 at 10:28:05PM +0200, Thomas Weißschuh wrote: > > > > > > On 2023-10-05 14:15:31-0600, Shuah Khan wrote: > > > > > > > Hi Thomas, > > > > > > > > > > > > > > On 10/5/23 11:00, Thomas Weißschuh wrote: > > > > > > > > Hi Shuah, > > > > > > > > > > > > > > > > I'd like to test the current state of nolibc in linux-next. > > > > > > > > Could pull the request below into your nolibc branch? > > > > > > > > > > > > > > > > I'll do some manual tests this weekend, too. > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Thomas > > > > > > > > > > > > > > > > > > > > > > > > The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: > > > > > > > > > > > > > > > > Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) > > > > > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git nolibc/next > > > > > > > > > > > > > > > > for you to fetch changes up to ab663cc32912914258bc8a2fbd0e753f552ee9d8: > > > > > > > > > > > > > > > > tools/nolibc: automatically detect necessity to use pselect6 (2023-09-28 09:20:35 +0200) > > > > > > > > > > > > > > Absolutely. Do you mind tagging and pushing the tag and send > > > > > > > pull request with the tag? > > > > > > > > > > > > Sure, here it is: > > > > > > > > > > > > > > > > > > The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: > > > > > > > > > > > > Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git nolibc-next.2023.10.05a > > > > > > > > > > > > for you to fetch changes up to ab663cc32912914258bc8a2fbd0e753f552ee9d8: > > > > > > > > > > > > tools/nolibc: automatically detect necessity to use pselect6 (2023-09-28 09:20:35 +0200) > > > > > > > > > > Looks good on my laptop: > > > > > > > > > > make run: > > > > > > > > > > 160 test(s): 160 passed, 0 skipped, 0 failed => status: success > > > > > > > > > > make run-user: > > > > > > > > > > 160 test(s): 158 passed, 2 skipped, 0 failed => status: warning > > > > > > > > > > Shuah, I can take nolibc for the upcoming merge window (I believe that > > > > > it is my turn to do so), but if you would prefer to take them, that also > > > > > works for me. Either way, just let me know. > > > > > > > > Yes it is your turn. Please go ahead and take them. > > > > > > Very good, I will merge them in and post them to the relevant email lists. > > > > > > > I will pull and do testing and update you on how it went. > > > > > > Looking forward to seeing what you find! > > > > In the list I'm seeing this one which is a fix for breakage introduced > > in 6.6-rc1: > > > > commit 3c9b7c4a228bf8cca2f92abb65575cdd54065302 (korg-nolibc/fixes, 20230830-nolibc-fixes) > > Author: Ammar Faizi > > Date: Wed Aug 30 08:02:23 2023 +0700 > > > > tools/nolibc: i386: Fix a stack misalign bug on _start > > > > The ABI mandates that the %esp register must be a multiple of 16 when > > executing a 'call' instruction. > > ... > > > > We'll have to send it separately so that it gets into 6.6 soon enough. > > And I think the update of the tree location in the MAINTAINERS file > > would be deserved as well. > > > > Paul, Shuah, what's the preferred way for you to get fixes for the current > > kernel now ? Do you prefer a PR based on a specific branch or just a patch ? > > The easiest for me would be if you rebased your stack on top of this > new fix, all still based on v6.6-rc1. I can then pull the new stack, > including fix, test it, and submit the fix to Linus in a few days, > assuming testing goes well. > > Would something else work better for you guys? With "stack" are you referring to only the fixes that are intended for v6.6? It sounds a bit like it should also included patches that are only meant for v6.7 . If it is only for the fixes, see below the request. Note that I dropped the patch "tools/nolibc: drop test for getauxval(AT_PAGESZ)" as it's not actually a fix. The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git fixes for you to fetch changes up to ac06a8400561f2e4f204e88c130970fb1b9f470c: MAINTAINERS: nolibc: update tree location (2023-10-07 12:41:14 +0200) ---------------------------------------------------------------- Ammar Faizi (1): tools/nolibc: i386: Fix a stack misalign bug on _start Thomas Weißschuh (1): MAINTAINERS: nolibc: update tree location MAINTAINERS | 2 +- tools/include/nolibc/arch-i386.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)