From: Mark Brown <broonie@kernel.org>
To: Shalini Manjunatha <quic_c_shalma@quicinc.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Raghu Bankapur <quic_rbankapu@quicinc.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krishna Jha <quic_kkishorj@quicinc.com>
Subject: Re: [PATCH V0 0/1] ASoC: soc-compress: Fix and add missing DPCM locking
Date: Wed, 6 Mar 2024 13:03:56 +0000 [thread overview]
Message-ID: <fae7335b-bb58-400a-9b72-936b0dcc2fc2@sirena.org.uk> (raw)
In-Reply-To: <cover.1709720380.git.quic_c_shalma@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Wed, Mar 06, 2024 at 04:23:19PM +0530, Shalini Manjunatha wrote:
> We find mising DPCM locking inside soc_compr_set_params_fe()
> before calling dpcm_be_dai_hw_params() and dpcm_be_dai_prepare()
> which cause lockdep assert for DPCM lock not held in
> __soc_pcm_hw_params() and __soc_pcm_prepare() in above flow
> when ever we play compress offload audio playback use case.
>
> To fix this issue added DPCM lock and unlock in both places of
> above code flow mentioned.
Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-06 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 10:53 Shalini Manjunatha
2024-03-06 10:53 ` [PATCH V0 1/1] ASoC: soc-compress: Fix and add " Shalini Manjunatha
2024-03-06 13:03 ` Mark Brown [this message]
2024-03-06 14:26 ` [PATCH V0 0/1] ASoC: soc-compress: Fix and add missing " Vinod Koul
2024-03-06 16:17 ` Mark Brown
2024-03-18 17:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae7335b-bb58-400a-9b72-936b0dcc2fc2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_c_shalma@quicinc.com \
--cc=quic_kkishorj@quicinc.com \
--cc=quic_rbankapu@quicinc.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®