From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7345837EFFC for ; Sat, 25 Jul 2026 08:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784968830; cv=none; b=dTcY6nqIAPzwIU81i/9VKPm0yYNNrs5ceLsrxDCmT3Uba8+SAbWNShnrEI4BOS/Am2P+RXQBUQKjOW+c1BACOqKQDNjdjKdFisvyqhlyyHxPNgQP4s+1Q8E8YD+2fBzdOb5OvYk+mF+t/kGtGw2bg5c+MOldrq9U7xnEWEpIqIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784968830; c=relaxed/simple; bh=mhgrRWx2k1e0VspUwC5Hb4XjyyrXhjarhKzEvd5EjT0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cnzUb6wRSI43A+Y6FusblmbDG38mKnaHmD0T4AySdln9zPIHhS3rstvG2tUOLp2K3fZnkfiEtz2vT43SmUlei/fk0BFQYckcHIww70p9g8XgfUU5mWcOf3tBu/uK8CVEKSZ5+WaEKYVmLoGzOGeodDW8tAgB+zRh12RmETVVsYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TBYegOfm; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TBYegOfm" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5aeb99bc721so143581e87.1 for ; Sat, 25 Jul 2026 01:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784968826; x=1785573626; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=MLYAlle2xVguW1DVr4k68CONNuO/IYqBXxeXFAFbzXM=; b=TBYegOfm8vI0OCWQao9jPyWSDCEXyf1mWWwS2G6AVVsWaNQxyQu6d+h0ybvu3/9Ffw cMO9BWvm3Sn41BQ2Gd78AerYDXFg0yjsJ1CAJwdfiQKKAgSngOKKIcS4zw7yUl2rYYDh iLAJ6bO8Vd76r6IoGqTXVe7yD1/6FB6ZwcaG9gJDFKdShzvtjqcIvxrMq7dDeJsRFhCK H5KckgAC0k47e5Vvkn2pofAbxEE6KiXsHuUD/ll6WOBYZS4O6FBHTtAzXayBs3/vEdmw A8ZinE8wyE6Kg/ZpmAZlg6xRbI21GJ4Jb/0HV2NuKMoPg85VHfYQNF/tbBgvc7zBQRq4 c+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784968826; x=1785573626; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MLYAlle2xVguW1DVr4k68CONNuO/IYqBXxeXFAFbzXM=; b=IIY5r5xyIjYgKq76mvz6fgO64NI/lP3h3+3Rm9aw7qQ8cQggAZ3UDvklNs/nQqOTJC 61RKqx+f1McdBP8OLObeWqy+TzaiDeONkUeyzaDeOgLoNJmQ/SfEWPLbSZPGdZExTQVQ ky4WGhOqMrN0Lk9boZCf0ppb98oDqVs/o7VA/HUm9hL/j4AKT6+JnPhjQZ39unacR4oN QGeL198BFXFHznqRb2/FYcLNCRIhP1aLBYXrerldVbfrM4yUtzFeEPoqonze5slKC8mW Dh6AtgzVGskDyMXdyF2gQcPsxQe3DOkbqgVyCFAvDN9NwRcky9og0nmB22WdlGqv7LHE IDSA== X-Forwarded-Encrypted: i=1; AHgh+RppvgjcM/TmBpVJCEfdYjhUf8uFw7C64SJoi1Ae0Dyd1UuNNFQzOmFeUJFsHkolqsgtWvihqmDwsAVCUaY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxxojl7ITyFE2cqZcajan0Q06yowQeg4wUaZmsKGA7mJLVDV26C z3Lz5gS6aOGD4Ag6UCd7XJ1Hk9ahY0QD4GzbWUZWU3C4srNpht2jfMcImzDaIOTHLRs= X-Gm-Gg: AR+sD11J0+NRaTKlmGSeP0iqPWIVTAJtdHh+h9Xzdoh1EcCOpOXxyOjmMkIF+EApvsH zlPZdg4yvaEdeYy0PjF1ZIn6yFG5kbfoSjRTQEpFlZZOrK0U8T6pHQ/MoCKRYvmkOQ6jQvtDun+ rm5TIBbg3f/vRdiyM7qgk+yhGaUCaErh1gX8VbT1uOQVchf9Z1KrxOplHp/V4bioVPG44pjwsyO 7dlLn4klJNBnstn4SaxDTdgeRcVGFVmma3RrNWVbdKUS5AIQpaz3qOZfKsUvcveOG9JD0noR9Sb pdCPrGhQobYo3AUel4xFeZPTu7v/HWE23NE//kL3VwiFI9LpNOATIu5GoNcKiHADehDDI2l4MSC ahN0aGd6UcUqeFy9s04yBJkUu2aFj02E6lxSWYom5aCYMU9l0x6t6ROVKxSYexZ63ZlEggwqCvU mjTgyoXxPJQuCI97yG4EawFkh7R4rTuUYFk5nw7QH18qKzcQxi5trcRE3w X-Received: by 2002:a05:6512:b27:b0:5ae:b844:2d4f with SMTP id 2adb3069b0e04-5b2c1b5d9famr166935e87.8.1784968826358; Sat, 25 Jul 2026 01:40:26 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2be08c619sm339094e87.34.2026.07.25.01.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2026 01:40:25 -0700 (PDT) Message-ID: Date: Sat, 25 Jul 2026 11:40:25 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate" To: Andi Shyti , Loic Poulain Cc: Robert Foss , Wolfram Sang , Dmitry Baryshkov , Luca Weiss , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> <20260721-cci-clk-fix-v1-1-5eae78700da8@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andi, On 7/25/26 01:57, Andi Shyti wrote: > Hi Loic, > > On Tue, Jul 21, 2026 at 04:58:19PM +0200, Loic Poulain wrote: >> This reverts commit b641af684fc28a07bee9c808eb6c433f9d9bcec6. >> >> The cci_clk_rate field is needed to enforce the correct CCI clock rate >> at probe time. The hw_params timing values are in clock ticks and were >> calibrated for a specific frequency per hardware variant, so running at >> the wrong rate would violate I2C timing specifications. >> >> Signed-off-by: Loic Poulain > > Does this revert need a Fixes tag? I haven't seen very often > reverts with Fixes tag, but it makes sense if they need to be > backported. > > I'm going to take patch 1 and 2 already while we discuss patch 3 > separately, but please let me know first if you agree adding the > Fixes tag. > please put all commits from this series on hold due to my last finding: https://lore.kernel.org/linux-arm-msm/8d20f3ab-696e-40a4-a05a-688779299071@linaro.org -- Best wishes, Vladimir