From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbcJMKf7 (ORCPT ); Thu, 13 Oct 2016 06:35:59 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:37206 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525AbcJMKfw (ORCPT ); Thu, 13 Oct 2016 06:35:52 -0400 Subject: Re: [PATCH] f2fs: fix wrong sum_page pointer in f2fs_gc To: Jaegeuk Kim , , , References: <20161012232304.6667-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Thu, 13 Oct 2016 18:33:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20161012232304.6667-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2016/10/13 7:23, Jaegeuk Kim wrote: > This patch fixes using a wrong pointer for sum_page in f2fs_gc. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e48142f..9c18917 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -854,16 +854,16 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > > for (segno = start_segno; segno < end_segno; segno++) { > > - if (get_valid_blocks(sbi, segno, 1) == 0 || > - unlikely(f2fs_cp_error(sbi))) > - goto next; > - > /* find segment summary of victim */ > sum_page = find_get_page(META_MAPPING(sbi), > GET_SUM_BLOCK(sbi, segno)); > - f2fs_bug_on(sbi, !PageUptodate(sum_page)); > f2fs_put_page(sum_page, 0); > > + if (get_valid_blocks(sbi, segno, 1) == 0 || > + !PageUptodate(sum_page) || Why uptodate flag of summary page can be cleared? someone truncates it? Thanks, > + unlikely(f2fs_cp_error(sbi))) > + goto next; > + > sum = page_address(sum_page); > f2fs_bug_on(sbi, type != GET_SUM_TYPE((&sum->footer))); > >