From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47359358D2D for ; Fri, 9 Jan 2026 09:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767949983; cv=none; b=jIRjAhNzioHZtwDbE+Li94JguMX91rI0VBoLT5/qQ7qcY84x+dHwXCiUNT8LBcNRuA0cW+zjdSEIelxG5ZnmUEvGqiiAusupon48NuDP/9LKNJyyJK1y6l/qxZSVYvNpCOA4v7SNwPRMCEWjdvHw6PINdB1Tq3ynITQz33rODZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767949983; c=relaxed/simple; bh=2PyzJYzP0Y1RqWMp6rzac5wFiZQD1KJFspE9qiO4mhQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YIROYNT6ebrV5v7GghZ4rWAZ65uswg4BJ3rnd0zQdOO2FIcsDn+BqUpCSDG0s9hCALnw9Hu9U0N9fo9MszGytmS5OylW0l625vhuYM/hFljw5adjMbV2fPznOP73/QuVxUDXR7UUplFIGbY0MwUO//9NsBGTpXBwQYtph+KLVY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YxoQLUak; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EyGqgbXR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YxoQLUak"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EyGqgbXR" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6091qRsk3324799 for ; Fri, 9 Jan 2026 09:13:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1P93m0XTzLapwNrcaQ2biPDhM8Asz8miZJjKBvF7vq8=; b=YxoQLUakCVzeOh88 ZqaK/OwdfAOF9sIZtVbbMX1FqVVQRdPVRy6AA/h/jNUsiKRnj8fw8zBmyc20k/3I gfkZ4sE1wlKql3l/BpUpXDKIOrSKKYiF0bxso7vZcnl2zK4Dx6sYxeoBprpe+IYv RQHzKrsshZaR4ZdtvawBNBJtgtJKWtxdvuvqajbUJeSATPZNQTMJ+jfGqbDhBOwF KKl8qlzD3tEo1F9xwTZimAxNBOMMUfd2DtakIxa3FohJyBz4F3KKeWAtN/yqxv8b 8LFSP/Cz1LwjmALIpsQLPUuu+l0MYZMlZly9QTGkSyjKZmMziEKrB5X1PPVqJEKc NMvsKA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjrd6h62q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 09:13:01 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b1be0fdfe1so124788985a.2 for ; Fri, 09 Jan 2026 01:13:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767949980; x=1768554780; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1P93m0XTzLapwNrcaQ2biPDhM8Asz8miZJjKBvF7vq8=; b=EyGqgbXR+tf+C3Ppyhi+xAqmrjQ5yFfo+SUI6X0s+GWxNT8CWBFbZtJtWKDS7iYpl8 RJtn7tHr24vwaonyTu6vQHzKUBTQXYs5B4djKKfKrnDHy2Fadn6u5LIwIeSZULGcJwWX vO/YdOqhy3KVxvDDv5QtkQtFcsfBZ+qruA1uoWXZfDxuFK5bs0EdtR6SU30Ho1jPxCLV 3xShs1UgAgYkubFC4TLhg0qvwTpbAmcA/FF5u6SODqT6XiVjuCFD72klMDQiOjahhhY9 DjyfEO/iNoea8AqeRgxqCCPNVTjTVASnrgsuFhDPq7lPreMCO1M0n+uJcy1BdFyG1aNR GPKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767949980; x=1768554780; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1P93m0XTzLapwNrcaQ2biPDhM8Asz8miZJjKBvF7vq8=; b=o9H1uCJPI337n1+Tk/zAzj8HgQ8wuvApZ31AvFs9t+1cJqwgxk6NGjlfO+fRHXl/Tl 9Epi8r8WYqhR/2G3bKIHcZE07Gc0NQS2RxscpzUh55ss8hRyorIjO1MY/BiBcAw+lt18 aUo/D4VnZvjX3yx3RVMaT5FBEE38JyjqrswgrhrmnIypbdLco3UPc35wagQlO3fPHzhF 1UHpwYHrhZv+zF8GzGNtmUk8hjiClTYYYSyBMT+YwULQsIe0L06+FBAqIgsvkT+I5T33 vHb89YL3OYFsiQaEq2NdvphVIatPJE2QMd6KlNbYyuN65gtXa8qEfVX2mjDJ76WKIiB9 /WDQ== X-Forwarded-Encrypted: i=1; AJvYcCU10+L5LhRtoJWJ83QNK7ZG9yeNq2i9Xmd9hZfQuzU7yKyeTfZx4moQlH2nBIkAphlRvq8T1oJm8JBlGsM=@vger.kernel.org X-Gm-Message-State: AOJu0YxGPn6C95n41Cr4I+8/NuT1iOCouimFlvKjsZVXL32jqs1nEgIq 3Us8DpMMFPpVIAq5nY7ObZyRo17zLwUHmarACEBQFN13slnE+5FJCmJNgh01EAt/r51boCrkiW7 N/UrADMdG79ksynE5m8q982QGK/fU2t+CRDqqy/+ay871V8S/qK3JB6g1VvbHPnLfZkA= X-Gm-Gg: AY/fxX5NMAZtMWdG92hOsiPw9ngHl+wX3mw3Ct+Ys5G9iDvzsSeblDy/VKHvYrnmO7g MtgOKoymsNcg6K0hqLTE6cXRbjSyKvNr/BSWV6aiA1zIJwBaRSnckS6TATxz3gO87ltn0j/UZe5 64r56AHxBGEpupiWyMaglvfmFiMFZD3JboxlJRsOJX/8btAZz4uZiAPUaWzd1qJm0ixcvOcJhzy RvHLxYU8oHGVTs+ZER40zVxJ/KNhq687/8mjxVl3/x0pQ5+6LKsBNpb4pSJzhq1bCN2Pwil+bOB Dh0GOVo2xtDPl+zMRobfPqpHmqRzTUvIYHrrqbPcGt9EZS2jO16EMXKX7Uc52aT68JUGe9AVEXj prTlktADphWxT2VayJu8ha2im1dYJEGrL7p5TQclMgmYA146owJk/S1gOUbSNtWHaXU0= X-Received: by 2002:a05:620a:2847:b0:8a5:2246:bc29 with SMTP id af79cd13be357-8c3893fd6f5mr926314085a.8.1767949980550; Fri, 09 Jan 2026 01:13:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeBZSG8kdSBLShp1+Wc/UybzJzIr8kq9RYBBSnMDG9wd87B0tyDpTBrTpAW7NtU14bEKYlTA== X-Received: by 2002:a05:620a:2847:b0:8a5:2246:bc29 with SMTP id af79cd13be357-8c3893fd6f5mr926312685a.8.1767949980148; Fri, 09 Jan 2026 01:13:00 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a5187afsm1043952666b.58.2026.01.09.01.12.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 01:12:59 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2026 10:12:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24/27] drm/msm/dsi_phy_14nm: convert from divider_round_rate() to divider_determine_rate() To: Brian Masney , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> <20260108-clk-divider-round-rate-v1-24-535a3ed73bf3@redhat.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260108-clk-divider-round-rate-v1-24-535a3ed73bf3@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA2NSBTYWx0ZWRfX+w1vCvzWU86C zKl3R2VY6AGmq7as/85z3I1lEEQeqnJgcjA3hSNfb//ZmiV5kFiAKRkZ9sYl7hFc1ulGreCFI8I CoXbgq9fX99sFr95H2OeB5JUpNNwfUlD3n/X8Kuh0Hg5JZIuGMJXwk5Pc2m8ECsuIuuq7Hd6/0k V044+1AQOQz2PN5aG18KTvQumd8ISrOkGz9gv8bA38HpdIEWvb/WMqF0B8w4yiKcXGOk8e7+Iao 7nwmWF5ktiGeKbrs/koOEHlEsGZy/NEoKFBDZOlPQKX9+6dt0g/ZHZ33y6f8bd7wymcoqoj9J6E OGEueizXllUjxi4Sh7q2G3szCcWnK22FOYhjAajBpUyyBK/rh37yRSyLdNdra8aX/rrYHnoGtlO vwvVMOSuvVyBhT1STZG/3i9jok8tOt7UJR9EmTinV8Z5cvsE6cne/kU7ttPPi7IfVJG5nkF0kR8 cudLY81j03urxB+P5tQ== X-Proofpoint-GUID: _rR3NoBkWZJEWC5ZxGKjRrL4mycC4RDO X-Proofpoint-ORIG-GUID: _rR3NoBkWZJEWC5ZxGKjRrL4mycC4RDO X-Authority-Analysis: v=2.4 cv=Xtf3+FF9 c=1 sm=1 tr=0 ts=6960c69d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=MmoDKESpECQAgM94Xi4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_02,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090065 On 1/8/26 10:16 PM, Brian Masney wrote: > The divider_round_rate() function is now deprecated, so let's migrate > to divider_determine_rate() instead so that this deprecated API can be > removed. > > Note that when the main function itself was migrated to use > determine_rate, this was mistakenly converted to: > > req->rate = divider_round_rate(...) > > This is invalid in the case when an error occurs since it can set the > rate to a negative value. > > Fixes: cc41f29a6b04 ("drm/msm/dsi_phy_14nm: convert from round_rate() to determine_rate()") > Signed-off-by: Brian Masney > > --- Reviewed-by: Konrad Dybcio Konrad