From: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
To: outreachy@lists.linux.dev, julia.lawall@inria.fr
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, david.laight.linux@gmail.com,
dan.carpenter@linaro.org, andy@kernel.org,
Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Subject: [PATCH v8 1/2] staging: rtl8723bs: Add spaces and line breaks to improve readability
Date: Tue, 8 Apr 2025 15:41:56 +0000 [thread overview]
Message-ID: <faf8f6f9ae2b0e4ca37ece39a33db6ea79e025c3.1744126058.git.abrahamadekunle50@gmail.com> (raw)
In-Reply-To: <cover.1744126058.git.abrahamadekunle50@gmail.com>
The code contains no spaces around binary operators with long lines
which reduces readability thereby not adhering to Linux kernel coding
style.
Add white spaces around the binary operators and use line breaks to
increase readability and ensure adherence to Linux kernel coding
styles.
Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 297c93d65315..5def2467f42b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -963,11 +963,14 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
if (SN_LESS(pattrib->seqnum, tx_seq)) {
pattrib->ampdu_en = false;/* AGG BK */
} else if (SN_EQUAL(pattrib->seqnum, tx_seq)) {
- psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
+ psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =
+ (tx_seq + 1) & 0xfff;
pattrib->ampdu_en = true;/* AGG EN */
} else {
- psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
+ psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =
+ (pattrib->seqnum + 1) & 0xfff;
+
pattrib->ampdu_en = true;/* AGG EN */
}
}
--
2.34.1
next prev parent reply other threads:[~2025-04-08 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 15:41 [PATCH v8 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping Abraham Samuel Adekunle
2025-04-08 15:41 ` Abraham Samuel Adekunle [this message]
2025-04-08 15:41 ` [PATCH v8 2/2] staging: rtl8723bs: Use % 4096 instead of & 0xfff Abraham Samuel Adekunle
2025-04-08 19:41 ` [PATCH v8 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping Andy Shevchenko
2025-04-08 21:04 ` Samuel Abraham
2025-04-09 2:11 ` Julia Lawall
2025-04-09 8:53 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faf8f6f9ae2b0e4ca37ece39a33db6ea79e025c3.1744126058.git.abrahamadekunle50@gmail.com \
--to=abrahamadekunle50@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=david.laight.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®