From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384961B59A for ; Fri, 26 Jan 2024 09:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706260646; cv=none; b=Fx8BTM5843rHrC8Z36TVpXt0NY3Gqavt57bvkITMC93W6MKDlNLz5biv8Culz4/FIy59GUVarb/AgWb7eUrhWd7UNkXLR6dSNFRNp9EFqBwQI168RncdjvzKtLBJvGRnWdNDs7jx7fyn8myP8SkkgbLOjzBQYfzRBzW0tWDiaTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706260646; c=relaxed/simple; bh=+L0SrYmkZC5SWVkFnnUR9xTR/K+GM9/r1ecUb9WIAQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C3cxBZLRPOjCXtQYzsKLMubQxpqFS17OGmpZMSZYDhxmJI9QATVxoES3JxAaxiWWxLKyPe97S7GVTz+Qd8GlbPMjsqgA3A/VJPb0qHKNS3kUSSy57lAtfIUQ7/Q3AGjXupUm3yRHaxYTdONfDEndb/lKan+u2TGWZ2w9bTcT51E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 460be78cba3e40d0890baf0c874365d0-20240126 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:2c2a72b2-8f7f-4010-ad7a-03412aec4111,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.35,REQID:2c2a72b2-8f7f-4010-ad7a-03412aec4111,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:5d391d7,CLOUDID:677bc97f-4f93-4875-95e7-8c66ea833d57,B ulkID:2401261428140T0ET36M,BulkQuantity:5,Recheck:0,SF:17|19|44|64|66|38|2 4|102,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil, COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 460be78cba3e40d0890baf0c874365d0-20240126 Received: from mail.kylinos.cn [(39.156.73.10)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1222685538; Fri, 26 Jan 2024 17:11:50 +0800 Received: from mail.kylinos.cn (localhost [127.0.0.1]) by mail.kylinos.cn (NSMail) with SMTP id C449FE000EB9; Fri, 26 Jan 2024 17:11:49 +0800 (CST) X-ns-mid: postfix-65B37755-723417383 Received: from [172.20.15.234] (unknown [172.20.15.234]) by mail.kylinos.cn (NSMail) with ESMTPA id 897DCE000EB9; Fri, 26 Jan 2024 17:11:40 +0800 (CST) Message-ID: Date: Fri, 26 Jan 2024 17:11:39 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] powerpc/cell: Code cleanup for spufs_mfc_flush To: Arnd Bergmann , Jeremy Kerr , Michael Ellerman , Nicholas Piggin , Christophe Leroy , aneesh.kumar@kernel.org, "Naveen N. Rao" Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20240126021258.574916-1-chentao@kylinos.cn> Content-Language: en-US From: Kunwu Chan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/1/26 14:27, Arnd Bergmann wrote: > On Fri, Jan 26, 2024, at 03:12, Kunwu Chan wrote: >> This part was commented from commit a33a7d7309d7 >> ("[PATCH] spufs: implement mfc access for PPE-side DMA") >> in about 18 years before. >> >> If there are no plans to enable this part code in the future, >> we can remove this dead code. >> >> Signed-off-by: Kunwu Chan >> Suggested-by: Christophe Leroy > > Nobody is actively working on this code, so it clearly won't > be needed in the future. > > Acked-by: Arnd Bergmann > > On the other hand there is probably little use in removing > the dead code either. It looks you sent a lot of these > patches with identical changelog texts to remove blocks > of dead code, which does not seem productive to me as > these were clearly all left in the code to document > something. Yes, I was doing some cleanup of useless code the other day. The previous patches were submitted to remove some code that had been unused for a long time and was ineffective. I didn't remove the comments in the header file and the debugging-related parts. Because these parts may be used later. Thank you very much for the reminder.I'll pay attention to whether it has a document feature later. > > Arnd -- Thanks, Kunwu